Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(59)

Issue 3012233002: Remove #include of rtc_stream_config.h from rtc_event_log.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 23 hours ago by eladalon
Modified:
4 days, 20 hours ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove #include of rtc_stream_config.h from rtc_event_log.h StreamConfig is not integral to RTC-event logging in general, but rather to specific events. Therefore, the dependency on it should not be exported through rtc_event_log.h. BUG=webrtc:8111

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M webrtc/call/call.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/rtc_tools/event_log_visualizer/analyzer.cc View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:  win_msvc_rel   linux_tsan2   mac_chromium_rel_ng   ios-device   android_compile_dbg   linux_android_rel_ng   win_chromium_rel_ng   linux_chromium_rel_ng   android_more_configs   ios64_sim_ios10_dbg   ios_arm64_rel   android_compile_arm64_dbg   linux_compile_rel   linux_more_configs   mac_compile_dbg   ios_rel   win_compile_x64_rel   linux_compile_dbg   ios_dbg   win_compile_x64_dbg   linux_libfuzzer_rel   android_compile_x86_dbg   android_compile_rel   android_clang_dbg   android_compile_x64_dbg   win_compile_dbg   ios_arm64_dbg   android_compile_arm64_rel   mac_compile_rel   win_x64_clang_rel   win_clang_dbg   ios32_sim_ios9_dbg   win_clang_rel   android_compile_dbg   win_x64_clang_dbg   win_compile_rel   win_msvc_rel   linux_tsan2   mac_chromium_rel_ng   ios-device   linux_android_rel_ng   android_compile_dbg   win_chromium_rel_ng   linux_chromium_rel_ng   win_compile_dbg   android_compile_x64_dbg   mac_compile_rel   android_compile_arm64_rel   linux_more_configs   win_compile_rel   win_clang_dbg   win_x64_clang_rel   win_compile_x64_dbg   android_clang_dbg   android_compile_arm64_dbg   ios_rel   linux_libfuzzer_rel   ios_dbg   win_clang_rel   ios32_sim_ios9_dbg   win_compile_x64_rel   win_x64_clang_dbg   android_compile_rel   android_compile_dbg   linux_compile_rel   ios_arm64_dbg   ios_arm64_rel   mac_compile_dbg   android_more_configs   ios64_sim_ios10_dbg   linux_compile_dbg   android_compile_x86_dbg 
Commit queue not available (can’t edit this change).

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
eladalon
PTAL
5 days, 23 hours ago (2017-09-13 12:07:27 UTC) #2
terelius
lgtm
5 days, 23 hours ago (2017-09-13 12:20:56 UTC) #3
eladalon
4 days, 20 hours ago (2017-09-14 14:58:41 UTC) #4

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b