Issue 3012233002: Remove #include of rtc_stream_config.h from rtc_event_log.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3012233002: Remove #include of rtc_stream_config.h from rtc_event_log.h (Closed)

Created:
3 years, 3 months ago by eladalon

Modified:
3 years, 3 months ago

Reviewers:
terelius

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Remove #include of rtc_stream_config.h from rtc_event_log.h StreamConfig is not integral to RTC-event logging in general, but rather to specific events. Therefore, the dependency on it should not be exported through rtc_event_log.h. BUG=webrtc:8111

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased #

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
M	webrtc/call/call.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/logging/rtc_event_log/rtc_event_log.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webrtc/logging/rtc_event_log/rtc_event_log.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/logging/rtc_event_log/rtc_event_log_parser.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/logging/rtc_event_log/rtc_event_log_parser.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/rtc_tools/event_log_visualizer/analyzer.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 3014503002 Patch 1

Dependent Patchsets:

Issue 3012273002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eladalon

3 years, 3 months ago (2017-09-14 14:58:41 UTC) #4

Moved to https://webrtc-review.googlesource.com/#/c/src/+/1238

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages