Issue 3014503002: RtcEventLog::Create() no longer a friend of RtcEventLogImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3014503002: RtcEventLog::Create() no longer a friend of RtcEventLogImpl (Closed)

Created:
3 years, 3 months ago by eladalon

Modified:
3 years, 3 months ago

Reviewers:
terelius

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

RtcEventLog::Create() no longer a friend of RtcEventLogImpl By making RtcEventLogImpl's ctor public, we remove the necessity to make the function a friend. Visibility of RtcEventLogImpl is still limited to the .cc file. BUG=webrtc:8111

Patch Set 1 #

Patch Set 2 : Piggyback namespace change. #

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
	M	webrtc/logging/rtc_event_log/rtc_event_log.cc	View	1	4 chunks	+3 lines, -12 lines	0 comments	Download

Depends on Patchset:

Issue 3012263002 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eladalon

3 years, 3 months ago (2017-09-14 14:57:45 UTC) #3

This was moved to https://webrtc-review.googlesource.com/c/src/+/1237

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages