Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 3012033002: Revert of Smoke test for heap profiler. (Closed)

Created:
3 years, 3 months ago by nednguyen
Modified:
3 years, 3 months ago
Reviewers:
perezju, kraynov
CC:
picksi, xunjieli
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Smoke test for heap profiler. (patchset #2 id:20001 of https://codereview.chromium.org/3010173002/ ) Reason for revert: Broke catapult roll Original issue's description: > Smoke test for heap profiler. > > This test checks that heap profiler produced dumps. > > BUG=chromium:670828 > > Review-Url: https://chromiumcodereview.appspot.com/3010173002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c5a474f50f94f4df9cf979c1e7accc5515c79ca7 TBR=perezju@chromium.org,kraynov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:670828 Review-Url: https://chromiumcodereview.appspot.com/3012033002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6eb061ae61ff312dc3b5bea56ecab13c0d507a21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -42 lines) Patch
M telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py View 4 chunks +3 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nednguyen
Created Revert of Smoke test for heap profiler.
3 years, 3 months ago (2017-09-07 14:04:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3012033002/1
3 years, 3 months ago (2017-09-07 14:04:19 UTC) #3
kraynov
lgtm Will check against DCHECK-enabled build before re-landing.
3 years, 3 months ago (2017-09-07 14:08:35 UTC) #4
commit-bot: I haz the power
3 years, 3 months ago (2017-09-07 14:31:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698