Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3010173002:
Smoke test for heap profiler. (Closed)
DescriptionSmoke test for heap profiler.
This test checks that heap profiler produced dumps.
BUG=chromium:670828
Review-Url: https://chromiumcodereview.appspot.com/3010173002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c5a474f50f94f4df9cf979c1e7accc5515c79ca7
Patch Set 1 #Patch Set 2 : exclude reference builds #Messages
Total messages: 23 (14 generated)
kraynov@chromium.org changed reviewers: + perezju@chromium.org
PTAL Thanks!
The CQ bit was checked by kraynov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)
The CQ bit was checked by kraynov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
perezju@chromium.org changed reviewers: + nednguyen@google.com
lgtm if the tests pass +Ned FYI
On 2017/09/06 10:42:02, perezju wrote: > lgtm if the tests pass > > +Ned FYI is this not testing that there is any meaningul content in the heap profiler?
Not yet, but it's the matter of TBM metric. It can be improved by adding assertions in that function https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/met...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kraynov@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1504697065730620,
"parent_rev": "c9667ecd29cbb003b7fbdcd6f2da0f02bf0e7257", "commit_rev":
"c5a474f50f94f4df9cf979c1e7accc5515c79ca7"}
Message was sent while issue was closed.
Description was changed from ========== Smoke test for heap profiler. This test checks that heap profiler produced dumps. BUG=chromium:670828 ========== to ========== Smoke test for heap profiler. This test checks that heap profiler produced dumps. BUG=chromium:670828 Review-Url: https://chromiumcodereview.appspot.com/3010173002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
Message was sent while issue was closed.
This CL broke Catapult autoroll (https://catapult-roll.skia.org/) Can we revert?
Message was sent while issue was closed.
Description was changed from ========== Smoke test for heap profiler. This test checks that heap profiler produced dumps. BUG=chromium:670828 Review-Url: https://chromiumcodereview.appspot.com/3010173002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ========== to ========== Smoke test for heap profiler. This test checks that heap profiler produced dumps. BUG=chromium:670828 Review-Url: https://chromiumcodereview.appspot.com/3010173002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/3012033002/ by nednguyen@google.com. The reason for reverting is: Broke catapult roll.
Message was sent while issue was closed.
On 2017/09/07 14:04:09, nednguyen wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/3012033002/ by mailto:nednguyen@google.com. > > The reason for reverting is: Broke catapult roll. Reverting sgtm. Thanks Ned. |
