dashboard/dashboard/pinpoint/models/attempt.py - Issue 3010873003: [pinpoint] Limit executions to one test run each + device sharding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/pinpoint/models/attempt.py

Issue 3010873003: [pinpoint] Limit executions to one test run each + device sharding. (Closed)

Patch Set: Ready! Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dashboard/dashboard/pinpoint/models/attempt.py

diff --git a/dashboard/dashboard/pinpoint/models/attempt.py b/dashboard/dashboard/pinpoint/models/attempt.py

index a8aeaad33b849e985282ff2aeea3dd0614be72de..3fc153ff6067110e4bd436ba44e1a9e515c62fd7 100644

--- a/dashboard/dashboard/pinpoint/models/attempt.py

+++ b/dashboard/dashboard/pinpoint/models/attempt.py

@@ -73,9 +73,8 @@ class Attempt(object):

return

next_quest = self._quests[len(self._executions)]

+ arguments = {'change': self._change}

if self._executions:

- arguments = self._last_execution.result_arguments

- else:

- arguments = {'change': self._change}

+ arguments.update(self._last_execution.result_arguments)

self._executions.append(next_quest.Start(**arguments))