Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2674)

Unified Diff: dashboard/dashboard/pinpoint/handlers/quest_generator_test.py

Issue 3010873003: [pinpoint] Limit executions to one test run each + device sharding. (Closed)
Patch Set: Ready! Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/handlers/quest_generator_test.py
diff --git a/dashboard/dashboard/pinpoint/handlers/quest_generator_test.py b/dashboard/dashboard/pinpoint/handlers/quest_generator_test.py
index 6e5515b7784e511c7d9b74839cdca08665b8eb9b..7c4fd15bf4f826274c5a85cf94b8877583d8c333 100644
--- a/dashboard/dashboard/pinpoint/handlers/quest_generator_test.py
+++ b/dashboard/dashboard/pinpoint/handlers/quest_generator_test.py
@@ -9,7 +9,7 @@ from dashboard.pinpoint.models import quest
_MIN_TELEMETRY_RUN_TEST_ARGUMENTS = [
- 'speedometer', '--pageset-repeat', '10', '--browser', 'release',
+ 'speedometer', '--pageset-repeat', '1', '--browser', 'release',
'-v', '--upload-results', '--output-format', 'chartjson',
'--isolated-script-test-output', '${ISOLATED_OUTDIR}/output.json',
'--isolated-script-test-chartjson-output',
@@ -19,7 +19,17 @@ _MIN_TELEMETRY_RUN_TEST_ARGUMENTS = [
_ALL_TELEMETRY_RUN_TEST_ARGUMENTS = [
'speedometer', '--story-filter', 'http://www.fifa.com/',
- '--pageset-repeat', '50', '--browser', 'release',
+ '--pageset-repeat', '1', '--browser', 'release',
+ '-v', '--upload-results', '--output-format', 'chartjson',
+ '--isolated-script-test-output', '${ISOLATED_OUTDIR}/output.json',
+ '--isolated-script-test-chartjson-output',
+ '${ISOLATED_OUTDIR}/chartjson-output.json',
+]
+
+
+_STARTUP_BENCHMARK_RUN_TEST_ARGUMENTS = [
+ 'start_with_url.warm.startup_pages',
+ '--pageset-repeat', '2', '--browser', 'release',
'-v', '--upload-results', '--output-format', 'chartjson',
'--isolated-script-test-output', '${ISOLATED_OUTDIR}/output.json',
'--isolated-script-test-chartjson-output',
@@ -28,7 +38,7 @@ _ALL_TELEMETRY_RUN_TEST_ARGUMENTS = [
_MIN_GTEST_RUN_TEST_ARGUMENTS = [
- '--gtest_repeat=10',
+ '--gtest_repeat=1',
'--isolated-script-test-output', '${ISOLATED_OUTDIR}/output.json',
'--isolated-script-test-chartjson-output',
'${ISOLATED_OUTDIR}/chartjson-output.json',
@@ -36,7 +46,7 @@ _MIN_GTEST_RUN_TEST_ARGUMENTS = [
_ALL_GTEST_RUN_TEST_ARGUMENTS = [
- '--gtest_filter=test_name', '--gtest_repeat=50',
+ '--gtest_filter=test_name', '--gtest_repeat=1',
'--isolated-script-test-output', '${ISOLATED_OUTDIR}/output.json',
'--isolated-script-test-chartjson-output',
'${ISOLATED_OUTDIR}/chartjson-output.json',
@@ -115,7 +125,6 @@ class TelemetryRunTest(unittest.TestCase):
'benchmark': 'speedometer',
'browser': 'release',
'story': 'http://www.fifa.com/',
- 'repeat_count': '50',
}
expected_quests = [
@@ -125,6 +134,22 @@ class TelemetryRunTest(unittest.TestCase):
self.assertEqual(quest_generator.GenerateQuests(arguments),
(arguments, expected_quests))
+ def testStartupBenchmarkRepeatCount(self):
+ arguments = {
+ 'configuration': 'chromium-rel-mac11-pro',
+ 'target': 'telemetry_perf_tests',
+ 'dimensions': '{}',
+ 'benchmark': 'start_with_url.warm.startup_pages',
+ 'browser': 'release',
+ }
+
+ expected_quests = [
+ quest.FindIsolate('chromium-rel-mac11-pro', 'telemetry_perf_tests'),
+ quest.RunTest({}, _STARTUP_BENCHMARK_RUN_TEST_ARGUMENTS),
+ ]
+ self.assertEqual(quest_generator.GenerateQuests(arguments),
+ (arguments, expected_quests))
+
class GTestRunTest(unittest.TestCase):
@@ -149,7 +174,6 @@ class GTestRunTest(unittest.TestCase):
'target': 'net_perftests',
'dimensions': '{"key": "value"}',
'test': 'test_name',
- 'repeat_count': '50',
}
expected_quests = [
@@ -189,7 +213,6 @@ class ReadChartJsonValue(unittest.TestCase):
'benchmark': 'speedometer',
'browser': 'release',
'story': 'http://www.fifa.com/',
- 'repeat_count': '50',
'tir_label': 'pcv1-cold',
'chart': 'timeToFirst',
'trace': 'trace_name',
@@ -212,7 +235,6 @@ class ReadGraphJsonValue(unittest.TestCase):
'target': 'net_perftests',
'dimensions': '{"key": "value"}',
'test': 'test_name',
- 'repeat_count': '50',
'trace': 'trace_name',
}
@@ -224,7 +246,6 @@ class ReadGraphJsonValue(unittest.TestCase):
'target': 'net_perftests',
'dimensions': '{"key": "value"}',
'test': 'test_name',
- 'repeat_count': '50',
'chart': 'chart_name',
}
@@ -237,7 +258,6 @@ class ReadGraphJsonValue(unittest.TestCase):
'target': 'net_perftests',
'dimensions': '{"key": "value"}',
'test': 'test_name',
- 'repeat_count': '50',
'chart': 'chart_name',
'trace': 'trace_name',
}

Powered by Google App Engine
This is Rietveld 408576698