Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Unified Diff: dashboard/dashboard/pinpoint/handlers/quest_generator.py

Issue 3010873003: [pinpoint] Limit executions to one test run each + device sharding. (Closed)
Patch Set: Ready! Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/handlers/quest_generator.py
diff --git a/dashboard/dashboard/pinpoint/handlers/quest_generator.py b/dashboard/dashboard/pinpoint/handlers/quest_generator.py
index 136ca9b927163a8bc943e52a6da4f81f60ae9fa6..29a4df255baad730e395422ba6a1d40e6384314a 100644
--- a/dashboard/dashboard/pinpoint/handlers/quest_generator.py
+++ b/dashboard/dashboard/pinpoint/handlers/quest_generator.py
@@ -84,12 +84,12 @@ def _TelemetryRunTest(request):
arguments['story'] = story
swarming_extra_args += ('--story-filter', story)
- repeat_count = request.get('repeat_count')
- if repeat_count:
- arguments['repeat_count'] = repeat_count
+ # TODO: Workaround for crbug.com/677843.
+ if (benchmark.startswith('startup.warm') or
+ benchmark.startswith('start_with_url.warm')):
+ swarming_extra_args += ('--pageset-repeat', '2')
perezju 2017/09/06 14:24:56 ugh :( Just saw that bug. Hope that gets eventual
else:
- repeat_count = str(_DEFAULT_REPEAT_COUNT)
- swarming_extra_args += ('--pageset-repeat', repeat_count)
+ swarming_extra_args += ('--pageset-repeat', '1')
browser = request.get('browser')
if not browser:
@@ -119,12 +119,7 @@ def _GTestRunTest(request):
arguments['test'] = test
swarming_extra_args.append('--gtest_filter=' + test)
- repeat_count = request.get('repeat_count')
- if repeat_count:
- arguments['repeat_count'] = repeat_count
- else:
- repeat_count = str(_DEFAULT_REPEAT_COUNT)
- swarming_extra_args.append('--gtest_repeat=' + repeat_count)
+ swarming_extra_args.append('--gtest_repeat=1')
swarming_extra_args += _SWARMING_EXTRA_ARGS
« no previous file with comments | « dashboard/dashboard/pinpoint/handlers/new_test.py ('k') | dashboard/dashboard/pinpoint/handlers/quest_generator_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698