Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(53)

Issue 3009333002: Create RtcEventLogEncoderLegacy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by eladalon
Modified:
4 days, 20 hours ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Create RtcEventLogEncoderLegacy We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL introduces RtcEventLogEncoderLegacy, which takes provides the encoding currently done by RtcEventLogImpl. After this, we can modify RtcEventLogImpl to use a dynamically chosen encoding, allowing us to easily choose between the current encoding and the new one on which we're working. BUG=webrtc:8111

Patch Set 1 #

Patch Set 2 : Fix ANA part. #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : Remove unused forward-declarations. #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+696 lines, -0 lines) Patch
M webrtc/logging/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/encoder/rtc_event_log_encoder.h View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.h View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc View 1 2 3 1 chunk +557 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (1 generated)
eladalon
1 week ago (2017-09-11 17:08:28 UTC) #2
PTAL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b