Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3012923002: Add the internals of RtcEvent's subclasses (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add the internals of RtcEvent's subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL adds the internals of RtcEvent's subclasses - the actual data that they keep. (Work on this was broken down into several CLs in order to make reviewing easier.) BUG=webrtc:8111

Patch Set 1 #

Total comments: 2

Patch Set 2 : RtcEventAudioPlayout #

Patch Set 3 : 1. Missing member. 2. Liberally spray consts. #

Patch Set 4 : Be even more liberal with consts. #

Patch Set 5 : RtcEvent remembers the time it was created (all sub-classes use it). #

Patch Set 6 : . #

Patch Set 7 : Rebased + some changes. #

Patch Set 8 : . #

Patch Set 9 : Rebased on top of solution for RTP-related dependency issues. #

Patch Set 10 : . #

Patch Set 11 : probe_cluster_id #

Patch Set 12 : explicit #

Patch Set 13 : . #

Patch Set 14 : Rebased #

Patch Set 15 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -16 lines) Patch
M webrtc/logging/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +9 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_audio_network_adaptation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_audio_network_adaptation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_audio_playout.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_audio_playout.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_audio_receive_stream_config.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +11 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_audio_receive_stream_config.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_audio_send_stream_config.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +11 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_audio_send_stream_config.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_bwe_update_delay_based.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_bwe_update_delay_based.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_bwe_update_loss_based.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_bwe_update_loss_based.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_probe_cluster_created.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_probe_cluster_created.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_probe_result_failure.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_probe_result_failure.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_probe_result_success.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_probe_result_success.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_rtcp_packet_incoming.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_rtcp_packet_incoming.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_rtcp_packet_outgoing.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_rtcp_packet_outgoing.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_rtp_packet_incoming.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_rtp_packet_incoming.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_rtp_packet_outgoing.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +10 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_rtp_packet_outgoing.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_video_receive_stream_config.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_video_receive_stream_config.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_video_send_stream_config.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/events/rtc_event_video_send_stream_config.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 3006263002 Patch 100001

Dependent Patchsets:

Issue 3009333002 Patch 100001

Messages

Total messages: 2 (1 generated)
eladalon
3 years, 3 months ago (2017-09-08 17:28:59 UTC) #2 
PTAL (% two files which are to be ignored)

https://codereview.webrtc.org/3012923002/diff/1/webrtc/logging/rtc_event_log/...
File webrtc/logging/rtc_event_log/events/rtc_event_audio_network_adaptation.cc
(right):

https://codereview.webrtc.org/3012923002/diff/1/webrtc/logging/rtc_event_log/...
webrtc/logging/rtc_event_log/events/rtc_event_audio_network_adaptation.cc:13:
#include <utility>
Please skip the changes in this file for now; there's a circular dependency
issue which I need to take care of.

https://codereview.webrtc.org/3012923002/diff/1/webrtc/logging/rtc_event_log/...
File webrtc/logging/rtc_event_log/events/rtc_event_audio_network_adaptation.h
(right):

https://codereview.webrtc.org/3012923002/diff/1/webrtc/logging/rtc_event_log/...
webrtc/logging/rtc_event_log/events/rtc_event_audio_network_adaptation.h:14:
#include <memory>
Please skip the changes in this file for now; there's a circular dependency
issue which I need to take care of.

Powered by Google App Engine
This is Rietveld 408576698