[pinpoint] Separate Execution exceptions from result_values.

[pinpoint] Separate Execution exceptions from result_values.

It's not good practice to mix types.

Having separate exception and result_values will make the UI easier, because it
don't have to guess whether result_values contains numeric data, or exception
strings, or a mixture of all 3. And it'll be easier to associate which results
go with which swarming task.

Execution.exception will always be a basestring, and Execution.result_values
will always be a tuple of numbers.

Review-Url: https://chromiumcodereview.appspot.com/3008183002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d06e58b78cbe562bcd2a98771cb109e97a4f82c8

[dtu, 2017-09-06 01:24:52]

Description was changed from

==========
[pinpoint] Separate Execution exceptions from result_values.

It's not good practice to mix types.

Having separate exception and result_values will make the UI easier, because it
don't have to guess whether result_values contains numeric data or exception
strings or None.

Execution.exception will always be a basestring, and Execution.result_values
will always be a tuple of numbers.
==========

to

==========
[pinpoint] Separate Execution exceptions from result_values.

It's not good practice to mix types.

Having separate exception and result_values will make the UI easier, because it
don't have to guess whether result_values contains numeric data, or exception
strings, or a mixture of all 3. And it'll be easier to associate which results
go with which swarming task.

Execution.exception will always be a basestring, and Execution.result_values
will always be a tuple of numbers.
==========

[dtu, 2017-09-06 01:24:53]

dtu@chromium.org changed reviewers:
+ perezju@chromium.org, simonhatch@chromium.org, sullivan@chromium.org

[dtu, 2017-09-06 01:25:42]

Followup for https://codereview.chromium.org/3010873003/

[perezju, 2017-09-06 09:17:24]

https://codereview.chromium.org/3008183002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/job.py (right):

https://codereview.chromium.org/3008183002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/job.py:309: for quest in self._quests):
ehhh, this looks wrong. The loop variable is not used in the loop body.

[dtu, 2017-09-06 15:52:16]

Thanks! Sorry, the Job object doesn't have unit tests yet.

https://codereview.chromium.org/3008183002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/job.py (right):

https://codereview.chromium.org/3008183002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/job.py:309: for quest in self._quests):
On 2017/09/06 09:17:24, perezju wrote:
> ehhh, this looks wrong. The loop variable is not used in the loop body.

Done.

[perezju, 2017-09-07 12:52:55]

lgtm

[dtu, 2017-09-07 14:47:58]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2017-09-07 14:48:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-07 15:14:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1504795678311100,
"parent_rev": "2ed957724c2df2d0ae2c555564b00a0ca1622fc4", "commit_rev":
"d06e58b78cbe562bcd2a98771cb109e97a4f82c8"}

[commit-bot: I haz the power, 2017-09-07 15:14:43]

Description was changed from

==========
[pinpoint] Separate Execution exceptions from result_values.

It's not good practice to mix types.

Having separate exception and result_values will make the UI easier, because it
don't have to guess whether result_values contains numeric data, or exception
strings, or a mixture of all 3. And it'll be easier to associate which results
go with which swarming task.

Execution.exception will always be a basestring, and Execution.result_values
will always be a tuple of numbers.
==========

to

==========
[pinpoint] Separate Execution exceptions from result_values.

It's not good practice to mix types.

Having separate exception and result_values will make the UI easier, because it
don't have to guess whether result_values contains numeric data, or exception
strings, or a mixture of all 3. And it'll be easier to associate which results
go with which swarming task.

Execution.exception will always be a basestring, and Execution.result_values
will always be a tuple of numbers.

Review-Url: https://chromiumcodereview.appspot.com/3008183002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-07 15:14:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...