Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2294)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/run_test_test.py

Issue 3008183002: [pinpoint] Separate Execution exceptions from result_values. (Closed)
Patch Set: Fix exception loop Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/pinpoint/models/quest/read_value_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/pinpoint/models/quest/run_test_test.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/run_test_test.py b/dashboard/dashboard/pinpoint/models/quest/run_test_test.py
index 41889dbc36bfe71bfbfe44724fe1def2f842cf11..4bb00ba5c278433c935286a507cbe1f1cd7d7c59 100644
--- a/dashboard/dashboard/pinpoint/models/quest/run_test_test.py
+++ b/dashboard/dashboard/pinpoint/models/quest/run_test_test.py
@@ -106,16 +106,17 @@ class RunTestFullTest(_RunTestTest):
self.assertTrue(execution.completed)
self.assertFalse(execution.failed)
- self.assertEqual(execution.result_values, (None,))
+ self.assertEqual(execution.result_values, ())
self.assertEqual(execution.result_arguments,
{'isolate_hash': 'output isolate hash'})
self.assertEqual(
{
+ 'exception': None,
'bot_id': 'bot id',
'input_isolate_hash': 'input isolate hash',
'task_id': 'task id',
'result_arguments': {'isolate_hash': 'output isolate hash'},
- 'result_values': (None,),
+ 'result_values': (),
},
execution.AsDict())
@@ -148,9 +149,7 @@ class SwarmingTaskStatusTest(_RunTestTest):
self.assertTrue(execution.completed)
self.assertTrue(execution.failed)
- self.assertEqual(len(execution.result_values), 1)
- self.assertIsInstance(execution.result_values[0], basestring)
- last_exception_line = execution.result_values[0].splitlines()[-1]
+ last_exception_line = execution.exception.splitlines()[-1]
self.assertTrue(last_exception_line.startswith('SwarmingTaskError'))
def testTestError(self, swarming_task_result, swarming_tasks_new):
@@ -169,9 +168,7 @@ class SwarmingTaskStatusTest(_RunTestTest):
self.assertTrue(execution.completed)
self.assertTrue(execution.failed)
- self.assertEqual(len(execution.result_values), 1)
- self.assertIsInstance(execution.result_values[0], basestring)
- last_exception_line = execution.result_values[0].splitlines()[-1]
+ last_exception_line = execution.exception.splitlines()[-1]
self.assertTrue(last_exception_line.startswith('SwarmingTestError'))
@@ -205,9 +202,7 @@ class BotIdHandlingTest(_RunTestTest):
self.assertTrue(execution.completed)
self.assertTrue(execution.failed)
- self.assertEqual(len(execution.result_values), 1)
- self.assertIsInstance(execution.result_values[0], basestring)
- last_exception_line = execution.result_values[0].splitlines()[-1]
+ last_exception_line = execution.exception.splitlines()[-1]
self.assertTrue(last_exception_line.startswith('RunTestError'))
def testSimultaneousExecutions(self, swarming_task_result,
« no previous file with comments | « dashboard/dashboard/pinpoint/models/quest/read_value_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698