[Tracing] Add add_shared_diagnostics.AddValueDiagnostics

[Tracing] Add add_shared_diagnostics.AddValueDiagnostics

In preparation for adding tracing/bin/add_shared_diagnostics, which we intend to
support adding simple diagnostics directly, this CL adds a function
add_shared_diagnostics.AddValueDiagnostics.

In so doing, it pluralizes the AddSharedDiagnostics method to avoid
deserialization overhead, and moves away from using a JavaScript implementation
for simplicity's sake.

BUG=catapult:#3763

Review-Url: https://chromiumcodereview.appspot.com/3000643002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c59db25d81163ca4f159fbbcdaedad459d6f2a0d

[eakuefner, 2017-08-09 22:24:45]

eakuefner@chromium.org changed reviewers:
+ benjhayden@chromium.org

[eakuefner, 2017-08-09 22:24:45]

PTAL

[eakuefner, 2017-08-09 22:29:30]

Description was changed from

==========
[Tracing] Add add_shared_diagnostic.AddStringDiagnostic

In preparation for adding tracing/bin/add_shared_diagnostic, which we intend to
support adding simple diagnostics directly, this CL adds a function
add_shared_diagnostic.AddStringDiagnostic.

BUG=catapult:#3763
==========

to

==========
[Tracing] Add add_shared_diagnostic.AddValueDiagnostic

In preparation for adding tracing/bin/add_shared_diagnostic, which we intend to
support adding simple diagnostics directly, this CL adds a function
add_shared_diagnostic.AddValueDiagnostic.

BUG=catapult:#3763
==========

[benjhayden, 2017-08-10 20:13:38]

lgtm, feel free to pluralize them and/or change them to use the python
implementation in this CL.

[eakuefner, 2017-09-11 18:43:00]

Description was changed from

==========
[Tracing] Add add_shared_diagnostic.AddValueDiagnostic

In preparation for adding tracing/bin/add_shared_diagnostic, which we intend to
support adding simple diagnostics directly, this CL adds a function
add_shared_diagnostic.AddValueDiagnostic.

BUG=catapult:#3763
==========

to

==========
[Tracing] Add add_shared_diagnostics.AddValueDiagnostics

In preparation for adding tracing/bin/add_shared_diagnostics, which we intend to
support adding simple diagnostics directly, this CL adds a function
add_shared_diagnostics.AddValueDiagnostics.

In so doing, it pluralizes the AddSharedDiagnostics method to avoid
deserialization overhead, and moves away from using a JavaScript implementation
for simplicity's sake.

BUG=catapult:#3763
==========

[eakuefner, 2017-09-11 18:43:08]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2017-09-11 18:43:08]

Both done in this CL, thanks.

[eakuefner, 2017-09-11 18:43:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjhayden@chromium.org
Link to the patchset: https://codereview.chromium.org/3000643002/#ps40001
(title: "Address Ben's comments")

[commit-bot: I haz the power, 2017-09-11 18:43:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-11 20:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-11 20:01:08]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[eakuefner, 2017-09-11 20:07:42]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2017-09-11 20:07:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjhayden@chromium.org
Link to the patchset: https://codereview.chromium.org/3000643002/#ps60001
(title: "fix test")

[commit-bot: I haz the power, 2017-09-11 20:07:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-11 20:56:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1505160462336090,
"parent_rev": "6cd43e3fca04dcb22c2a3efe61fd629dfefe2d2f", "commit_rev":
"c59db25d81163ca4f159fbbcdaedad459d6f2a0d"}

[commit-bot: I haz the power, 2017-09-11 20:56:21]

Description was changed from

==========
[Tracing] Add add_shared_diagnostics.AddValueDiagnostics

In preparation for adding tracing/bin/add_shared_diagnostics, which we intend to
support adding simple diagnostics directly, this CL adds a function
add_shared_diagnostics.AddValueDiagnostics.

In so doing, it pluralizes the AddSharedDiagnostics method to avoid
deserialization overhead, and moves away from using a JavaScript implementation
for simplicity's sake.

BUG=catapult:#3763
==========

to

==========
[Tracing] Add add_shared_diagnostics.AddValueDiagnostics

In preparation for adding tracing/bin/add_shared_diagnostics, which we intend to
support adding simple diagnostics directly, this CL adds a function
add_shared_diagnostics.AddValueDiagnostics.

In so doing, it pluralizes the AddSharedDiagnostics method to avoid
deserialization overhead, and moves away from using a JavaScript implementation
for simplicity's sake.

BUG=catapult:#3763

Review-Url: https://chromiumcodereview.appspot.com/3000643002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-11 20:56:22]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...