Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: tracing/tracing/value/add_shared_diagnostic.py

Issue 3000643002: [Tracing] Add add_shared_diagnostics.AddValueDiagnostics (Closed)
Patch Set: fix test Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/value/add_shared_diagnostic_cmdline.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/add_shared_diagnostic.py
diff --git a/tracing/tracing/value/add_shared_diagnostic.py b/tracing/tracing/value/add_shared_diagnostic.py
deleted file mode 100644
index 1e4cbf53b03931da95d04cdf09a0e291a0b941a3..0000000000000000000000000000000000000000
--- a/tracing/tracing/value/add_shared_diagnostic.py
+++ /dev/null
@@ -1,34 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import os
-
-import tracing_project
-import vinn
-
-_ADD_SHARED_DIAGNOSTIC_CMD_LINE = os.path.join(
- os.path.dirname(__file__), 'add_shared_diagnostic_cmdline.html')
-
-
-def AddSharedDiagnostic(
- histograms_json_filename, diagnostic_name, diagnostic_filename):
- """Add a shared Diagnostic to a set of histograms.
-
- Args:
- histograms_json_filename: path to a histograms JSON file.
- diagnostic_name: name of diagnostic to add.
- diagnostic_filename: path to a diagnostic JSON file.
- Returns:
- Vinn result containing the new histograms JSON with added shared diagnostic.
- """
- project = tracing_project.TracingProject()
- all_source_paths = list(project.source_paths)
- return vinn.RunFile(
- _ADD_SHARED_DIAGNOSTIC_CMD_LINE,
- source_paths=all_source_paths,
- js_args=[
- os.path.abspath(histograms_json_filename),
- diagnostic_name,
- os.path.abspath(diagnostic_filename),
- ])
« no previous file with comments | « no previous file | tracing/tracing/value/add_shared_diagnostic_cmdline.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698