Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2999253002: Uncomment commented-out sequence-checks in call.cc (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 3 months ago
Reviewers:
the sun, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Uncomment commented-out sequence-checks in call.cc Two of the three commented-out checks should have been fixed by https://codereview.webrtc.org/2998923002/. The last will be fixed in a separate CL. BUG=webrtc:8116 Review-Url: https://codereview.webrtc.org/2999253002 Cr-Commit-Position: refs/heads/master@{#19511} Committed: https://chromium.googlesource.com/external/webrtc/+/d1dd2f79e5f290ef0f21f5c050aa0111732a0f71

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M webrtc/call/call.cc View 1 2 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
eladalon
PTAL https://codereview.webrtc.org/2999253002/diff/1/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2999253002/diff/1/webrtc/call/call.cc#newcode907 webrtc/call/call.cc:907: // TODO(solenberg): Some test cases in EndToEndTest use ...
3 years, 4 months ago (2017-08-18 14:37:58 UTC) #2
stefan-webrtc
LGTM, but there might be some problems with linux_internal
3 years, 4 months ago (2017-08-20 11:25:51 UTC) #3
eladalon
I don't remember if those problems were due to problems with importing WebRTC, or due ...
3 years, 3 months ago (2017-08-25 08:52:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999253002/40001
3 years, 3 months ago (2017-08-25 08:53:07 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-08-25 09:56:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/d1dd2f79e5f290ef0f21f5c05...

Powered by Google App Engine
This is Rietveld 408576698