Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: webrtc/call/call.cc

Issue 2999253002: Uncomment commented-out sequence-checks in call.cc (Closed)
Patch Set: Rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index f2bf27efa764f69f5bf0e4228b2d23338e90b762..cee00368221d531116f7a94ba0a3e96a322bc658 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -590,9 +590,7 @@ void Call::UpdateReceiveHistograms() {
}
PacketReceiver* Call::Receiver() {
- // TODO(solenberg): Some test cases in EndToEndTest use this from a different
- // thread. Re-enable once that is fixed.
- // RTC_DCHECK_CALLED_SEQUENTIALLY(&configuration_sequence_checker_);
+ RTC_DCHECK_CALLED_SEQUENTIALLY(&configuration_sequence_checker_);
return this;
}
@@ -1372,10 +1370,7 @@ PacketReceiver::DeliveryStatus Call::DeliverPacket(
const uint8_t* packet,
size_t length,
const PacketTime& packet_time) {
- // TODO(solenberg): Tests call this function on a network thread, libjingle
- // calls on the worker thread. We should move towards always using a network
- // thread. Then this check can be enabled.
- // RTC_DCHECK_CALLED_SEQUENTIALLY(&configuration_sequence_checker_);
+ RTC_DCHECK_CALLED_SEQUENTIALLY(&configuration_sequence_checker_);
if (RtpHeaderParser::IsRtcp(packet, length))
return DeliverRtcp(media_type, packet, length);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698