Move rtp dump writer from quality test to test transport

Move rtp dump writer from quality test to test transport

This makes it possible to use rtp dump when running video/screenshare
loopback test executables with renderers, not only using analyzer.

Also, make loopbacks exit if cmd line flags aren't set correctly.

BUG=None

Deprecated and moved to https://webrtc-review.googlesource.com/c/src/+/4360

[sprang_webrtc, 2017-08-23 07:43:46]

sprang@webrtc.org changed reviewers:
+ ilnik@webrtc.org, stefan@webrtc.org

[sprang_webrtc, 2017-08-23 07:43:46]

ilnik@, ptal
+stefan@ as owner for webrtc/test

[ilnik, 2017-08-23 08:24:25]

lgtm with nits.

https://codereview.webrtc.org/2997393002/diff/20001/webrtc/test/layer_filteri...
File webrtc/test/layer_filtering_transport.cc (right):

https://codereview.webrtc.org/2997393002/diff/20001/webrtc/test/layer_filteri...
webrtc/test/layer_filtering_transport.cc:19: #include
"webrtc/test/rtp_file_reader.h"
Why reader is needed here?

https://codereview.webrtc.org/2997393002/diff/20001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/2997393002/diff/20001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:54: #include "webrtc/test/rtp_file_writer.h"
This include should go after line 45.

[sprang_webrtc, 2017-08-23 10:32:05]

https://codereview.webrtc.org/2997393002/diff/20001/webrtc/test/layer_filteri...
File webrtc/test/layer_filtering_transport.cc (right):

https://codereview.webrtc.org/2997393002/diff/20001/webrtc/test/layer_filteri...
webrtc/test/layer_filtering_transport.cc:19: #include
"webrtc/test/rtp_file_reader.h"
On 2017/08/23 08:24:25, ilnik wrote:
> Why reader is needed here?

Oops. Autocomplete. rtp_file_writer was included from header, so it worked
anyway. change this and used a forward declaration in the header instead.

https://codereview.webrtc.org/2997393002/diff/20001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/2997393002/diff/20001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:54: #include "webrtc/test/rtp_file_writer.h"
On 2017/08/23 08:24:25, ilnik wrote:
> This include should go after line 45.

Done.

[sprang_webrtc, 2017-08-24 10:57:28]

Moved logging of rtp packets to _after_ fake network, otherwise we log packets
that could be dropped, and so the log won't repro what was seen in the loopback
test.

ptal

[stefan-webrtc, 2017-08-24 12:52:18]

https://codereview.webrtc.org/2997393002/diff/60001/webrtc/test/layer_filteri...
File webrtc/test/layer_filtering_transport.cc (right):

https://codereview.webrtc.org/2997393002/diff/60001/webrtc/test/layer_filteri...
webrtc/test/layer_filtering_transport.cc:119: PacketReceiver::DeliveryStatus
LayerFilteringTransport::DeliverPacket(
Maybe we should make this a feature of DirectTransport instead?

[sprang_webrtc, 2017-08-25 14:38:57]

On 2017/08/24 12:52:18, stefan-webrtc wrote:
>
https://codereview.webrtc.org/2997393002/diff/60001/webrtc/test/layer_filteri...
> File webrtc/test/layer_filtering_transport.cc (right):
> 
>
https://codereview.webrtc.org/2997393002/diff/60001/webrtc/test/layer_filteri...
> webrtc/test/layer_filtering_transport.cc:119: PacketReceiver::DeliveryStatus
> LayerFilteringTransport::DeliverPacket(
> Maybe we should make this a feature of DirectTransport instead?

Done.

[stefan-webrtc, 2017-08-26 07:48:52]

lgtm

[sprang_webrtc, 2017-08-29 08:45:23]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2017-08-29 08:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from ilnik@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2997393002/#ps80001 (title:
"move file writing from layer filtering transport to direct transport")

[commit-bot: I haz the power, 2017-08-29 08:45:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 08:47:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 08:47:21]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24445)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/28705)

[sprang_webrtc, 2017-08-29 10:56:38]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2017-08-29 10:56:38]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org,
ilnik@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2997393002/#ps100001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-08-29 10:56:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 10:58:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 10:58:31]

Try jobs failed on following builders:
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/23130)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/27559)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/28711)

[sprang_webrtc, 2017-08-29 11:16:54]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2017-08-29 11:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org,
ilnik@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2997393002/#ps120001 (title:
"Deps")

[commit-bot: I haz the power, 2017-08-29 11:17:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 11:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 11:42:11]

Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/21878)

[sprang_webrtc, 2017-09-28 13:41:06]

Description was changed from

==========
Move rtp dump writer from quality test to test transport

This makes it possible to use rtp dump when running video/screenshare
loopback test executables with renderers, not only using analyzer.

Also, make loopbacks exit if cmd line flags aren't set correctly.

BUG=None
==========

to

==========
Move rtp dump writer from quality test to test transport

This makes it possible to use rtp dump when running video/screenshare
loopback test executables with renderers, not only using analyzer.

Also, make loopbacks exit if cmd line flags aren't set correctly.

BUG=None

Deprecated and moved to https://webrtc-review.googlesource.com/c/src/+/4360
==========