Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: webrtc/video/video_loopback.cc

Issue 2997393002: Move rtp dump writer from quality test to test transport (Closed)
Patch Set: Deps Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/screenshare_loopback.cc ('k') | webrtc/video/video_quality_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_loopback.cc
diff --git a/webrtc/video/video_loopback.cc b/webrtc/video/video_loopback.cc
index bf0060986c10e81a3acf317ad78593e018b78f65..a0d33d7b0f76040dfc677a0a6f0c7d95bf345785 100644
--- a/webrtc/video/video_loopback.cc
+++ b/webrtc/video/video_loopback.cc
@@ -285,8 +285,8 @@ void Loopback() {
flags::GetCaptureDevice()};
params.audio = {flags::FLAG_audio, flags::FLAG_audio_video_sync,
flags::FLAG_audio_dtx};
- params.logging = {flags::FLAG_logs, flags::FLAG_rtc_event_log_name,
- flags::FLAG_rtp_dump_name, flags::FLAG_encoded_frame_path};
+ params.logging = {flags::FLAG_logs, flags::RtcEventLogName(),
+ flags::RtpDumpName(), flags::EncodedFramePath()};
params.screenshare.enabled = false;
params.analyzer = {"video", 0.0, 0.0, flags::DurationSecs(),
flags::OutputFilename(), flags::GraphTitle()};
@@ -318,8 +318,8 @@ void Loopback() {
int main(int argc, char* argv[]) {
::testing::InitGoogleTest(&argc, argv);
- rtc::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
- if (webrtc::flags::FLAG_help) {
+ int flags_status = rtc::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
+ if (webrtc::flags::FLAG_help || flags_status > 0) {
rtc::FlagList::Print(nullptr, false);
return 0;
}
« no previous file with comments | « webrtc/video/screenshare_loopback.cc ('k') | webrtc/video/video_quality_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698