Move rtp dump writer from quality test to test transport

webrtc/video/video_loopback.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 267 matching lines @@
                   flags::Codec(),
                   flags::NumTemporalLayers(),
                   flags::SelectedTL(),
                   0,  // No min transmit bitrate.
                   flags::FLAG_use_ulpfec,
                   flags::FLAG_use_flexfec,
                   flags::Clip(),
                   flags::GetCaptureDevice()};
   params.audio = {flags::FLAG_audio, flags::FLAG_audio_video_sync,
                   flags::FLAG_audio_dtx};
-  params.logging = {flags::FLAG_logs, flags::FLAG_rtc_event_log_name,
-                    flags::FLAG_rtp_dump_name, flags::FLAG_encoded_frame_path};
+  params.logging = {flags::FLAG_logs, flags::RtcEventLogName(),
+                    flags::RtpDumpName(), flags::EncodedFramePath()};
   params.screenshare.enabled = false;
   params.analyzer = {"video", 0.0, 0.0, flags::DurationSecs(),
       flags::OutputFilename(), flags::GraphTitle()};
   params.pipe = pipe_config;
 
   if (flags::NumStreams() > 1 && flags::Stream0().empty() &&
       flags::Stream1().empty()) {
     params.ss.infer_streams = true;
   }
 
@@ skipping 11 matching lines @@
   if (flags::DurationSecs()) {
     test.RunWithAnalyzer(params);
   } else {
     test.RunWithRenderers(params);
   }
 }
 }  // namespace webrtc
 
 int main(int argc, char* argv[]) {
   ::testing::InitGoogleTest(&argc, argv);
-  rtc::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
-  if (webrtc::flags::FLAG_help) {
+  int flags_status = rtc::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
+  if (webrtc::flags::FLAG_help || flags_status > 0) {
     rtc::FlagList::Print(nullptr, false);
     return 0;
   }
 
   // InitFieldTrialsFromString needs a reference to an std::string instance,
   // with a scope that outlives the test.
   std::string field_trials = webrtc::flags::FLAG_force_fieldtrials;
   webrtc::test::InitFieldTrialsFromString(field_trials);
 
   webrtc::test::RunTest(webrtc::Loopback);
   return 0;
 }