Move all the isolate reload code under !defined(DART_PRECOMPILED_RUNTIME)

Move all the isolate reload code under !defined(DART_PRECOMPILED_RUNTIME)

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/8039138f39e1379f2fa60d5ae9f0b997940c6618

[siva, 2017-08-18 23:42:08]

asiva@google.com changed reviewers:
+ zra@google.com

[zra, 2017-08-19 02:28:58]

https://codereview.chromium.org/2997243002/diff/40001/runtime/vm/isolate_relo...
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2997243002/diff/40001/runtime/vm/isolate_relo...
runtime/vm/isolate_reload.cc:28: DEFINE_FLAG(bool, trace_reload, false, "Trace
isolate reloading");
Is is possible to also exclude these flags?

https://codereview.chromium.org/2997243002/diff/40001/runtime/vm/runtime_entr...
File runtime/vm/runtime_entry.cc (right):

https://codereview.chromium.org/2997243002/diff/40001/runtime/vm/runtime_entr...
runtime/vm/runtime_entry.cc:1622: #if !defined(PRODUCT)
Is any of this possible in the precompiled runtime?

[siva, 2017-08-23 20:54:51]

https://codereview.chromium.org/2997243002/diff/40001/runtime/vm/isolate_relo...
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2997243002/diff/40001/runtime/vm/isolate_relo...
runtime/vm/isolate_reload.cc:28: DEFINE_FLAG(bool, trace_reload, false, "Trace
isolate reloading");
On 2017/08/19 02:28:58, zra wrote:
> Is is possible to also exclude these flags?

Done.

https://codereview.chromium.org/2997243002/diff/40001/runtime/vm/runtime_entr...
File runtime/vm/runtime_entry.cc (right):

https://codereview.chromium.org/2997243002/diff/40001/runtime/vm/runtime_entr...
runtime/vm/runtime_entry.cc:1622: #if !defined(PRODUCT)
On 2017/08/19 02:28:58, zra wrote:
> Is any of this possible in the precompiled runtime?

They are not used, changed this to
#if !defined(PRODUCT) && !defined(PRECOMPILED_RUNTIME)

[zra, 2017-08-23 21:14:31]

Can you upload the new patch set?

[siva, 2017-08-23 22:59:26]

sorry, here it is.

[zra, 2017-08-23 23:05:45]

lgtm

[siva, 2017-08-24 16:25:59]

Description was changed from

==========
Move all the isolate reload code under !defined(DART_PRECOMPILED_RUNTIME)
==========

to

==========
Move all the isolate reload code under !defined(DART_PRECOMPILED_RUNTIME)

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8039138f39e1379f2fa60d5ae9f0b997940c6618
==========

[siva, 2017-08-24 16:26:00]

Committed patchset #4 (id:60001) manually as
8039138f39e1379f2fa60d5ae9f0b997940c6618 (presubmit successful).