Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: runtime/vm/isolate.h

Issue 2997243002: Move all the isolate reload code under !defined(DART_PRECOMPILED_RUNTIME) (Closed)
Patch Set: Address code review comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef RUNTIME_VM_ISOLATE_H_ 5 #ifndef RUNTIME_VM_ISOLATE_H_
6 #define RUNTIME_VM_ISOLATE_H_ 6 #define RUNTIME_VM_ISOLATE_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "vm/atomic.h" 10 #include "vm/atomic.h"
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 #endif 508 #endif
509 509
510 // Mutator thread is used to aggregate compiler stats. 510 // Mutator thread is used to aggregate compiler stats.
511 CompilerStats* aggregate_compiler_stats() { 511 CompilerStats* aggregate_compiler_stats() {
512 return mutator_thread()->compiler_stats(); 512 return mutator_thread()->compiler_stats();
513 } 513 }
514 514
515 #if !defined(PRODUCT) 515 #if !defined(PRODUCT)
516 VMTagCounters* vm_tag_counters() { return &vm_tag_counters_; } 516 VMTagCounters* vm_tag_counters() { return &vm_tag_counters_; }
517 517
518 #if !defined(DART_PRECOMPILED_RUNTIME)
518 bool IsReloading() const { return reload_context_ != NULL; } 519 bool IsReloading() const { return reload_context_ != NULL; }
519 520
520 IsolateReloadContext* reload_context() { return reload_context_; } 521 IsolateReloadContext* reload_context() { return reload_context_; }
521 522
522 void DeleteReloadContext(); 523 void DeleteReloadContext();
523 524
524 bool HasAttemptedReload() const { 525 bool HasAttemptedReload() const {
525 return HasAttemptedReloadBit::decode(isolate_flags_); 526 return HasAttemptedReloadBit::decode(isolate_flags_);
526 } 527 }
527 void SetHasAttemptedReload(bool value) { 528 void SetHasAttemptedReload(bool value) {
528 isolate_flags_ = HasAttemptedReloadBit::update(value, isolate_flags_); 529 isolate_flags_ = HasAttemptedReloadBit::update(value, isolate_flags_);
529 } 530 }
530 531
531 bool CanReload() const; 532 bool CanReload() const;
532 533
533 void set_last_reload_timestamp(int64_t value) { 534 void set_last_reload_timestamp(int64_t value) {
534 last_reload_timestamp_ = value; 535 last_reload_timestamp_ = value;
535 } 536 }
536 int64_t last_reload_timestamp() const { return last_reload_timestamp_; } 537 int64_t last_reload_timestamp() const { return last_reload_timestamp_; }
538 #else
539 bool IsReloading() const { return false; }
540 bool HasAttemptedReload() const { return false; }
541 bool CanReload() const { return false; }
542 #endif // !defined(DART_PRECOMPILED_RUNTIME)
537 #endif // !defined(PRODUCT) 543 #endif // !defined(PRODUCT)
538 544
539 bool IsPaused() const; 545 bool IsPaused() const;
540 546
541 #if !defined(PRODUCT) 547 #if !defined(PRODUCT)
542 bool should_pause_post_service_request() const { 548 bool should_pause_post_service_request() const {
543 return ShouldPausePostServiceRequestBit::decode(isolate_flags_); 549 return ShouldPausePostServiceRequestBit::decode(isolate_flags_);
544 } 550 }
545 void set_should_pause_post_service_request(bool value) { 551 void set_should_pause_post_service_request(bool value) {
546 isolate_flags_ = 552 isolate_flags_ =
(...skipping 579 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 intptr_t* spawn_count_; 1132 intptr_t* spawn_count_;
1127 1133
1128 Dart_IsolateFlags isolate_flags_; 1134 Dart_IsolateFlags isolate_flags_;
1129 bool paused_; 1135 bool paused_;
1130 bool errors_are_fatal_; 1136 bool errors_are_fatal_;
1131 }; 1137 };
1132 1138
1133 } // namespace dart 1139 } // namespace dart
1134 1140
1135 #endif // RUNTIME_VM_ISOLATE_H_ 1141 #endif // RUNTIME_VM_ISOLATE_H_
OLDNEW
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698