Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2588)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2956593002: cl format

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dougt+watch_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, dmazzoni+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Typing feedback working in views BUG=657884

Patch Set 1 #

Patch Set 2 : It works \o/ #

Patch Set 3 : More #

Patch Set 4 : Sash - text markers not needed :/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -41 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 2 3 11 chunks +207 lines, -1 line 0 comments Download
M ui/accessibility/platform/text_marker_helper_mac.h View 1 2 2 chunks +7 lines, -10 lines 0 comments Download
M ui/accessibility/platform/text_marker_helper_mac.mm View 1 2 3 chunks +90 lines, -27 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (12 generated)
tapted
Description was changed from ========== cl format Typing feedback working in views BUG=657884 ========== to ...
3 years, 6 months ago (2017-06-23 07:21:10 UTC) #1
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-23 07:27:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956593002/20001
3 years, 6 months ago (2017-06-23 07:27:08 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-23 08:06:56 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/256488)
3 years, 6 months ago (2017-06-23 08:06:57 UTC) #5
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-25 23:17:14 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956593002/40001
3 years, 6 months ago (2017-06-25 23:18:06 UTC) #7
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-26 00:28:58 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956593002/60001
3 years, 6 months ago (2017-06-26 00:29:10 UTC) #9
tapted
Patchset #3 (id:40001) has been deleted
3 years, 6 months ago (2017-06-26 00:30:22 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-26 01:41:20 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-26 01:41:21 UTC) #12 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698