Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2940923003: a11y: Move CreateTextMarker[Range] to TextMarkerHelperMac.

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, je_julie, dmazzoni+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

a11y: Move CreateTextMarker[Range] to TextMarkerHelperMac. BUG=657884

Patch Set 1 : -tFlesh out most of TextMarkerHelperMac #

Patch Set 2 : self review #

Total comments: 6

Patch Set 3 : Self review pass #

Patch Set 4 : Rebase to master - I have an idea #

Patch Set 5 : the idea. nits, rebase [keep - I linked to this] #

Patch Set 6 : ugh compilers #

Patch Set 7 : squish? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+699 lines, -365 lines) Patch
M base/mac/foundation_util.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/mac/foundation_util.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 14 chunks +124 lines, -327 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
A ui/accessibility/ax_abstract_position.h View 1 2 3 4 5 6 1 chunk +116 lines, -0 lines 0 comments Download
A ui/accessibility/ax_abstract_position.cc View 1 2 3 4 5 1 chunk +26 lines, -0 lines 0 comments Download
M ui/accessibility/ax_position.h View 1 2 3 4 5 6 6 chunks +71 lines, -38 lines 0 comments Download
A ui/accessibility/platform/text_marker_helper_mac.h View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download
A ui/accessibility/platform/text_marker_helper_mac.mm View 1 2 3 4 5 6 1 chunk +293 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 36 (35 generated)
tapted
3 years, 6 months ago (2017-06-19 11:44:31 UTC) #8 
https://codereview.chromium.org/2940923003/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/2940923003/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_cocoa.mm:953: -
(id)startTextMarker {
(self review: swap order with endTextMarker)

https://codereview.chromium.org/2940923003/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_cocoa.mm:2077: SEL selector
= NSSelectorFromString(attribute);
(self review: this needs a colon appended to the string it (or a static map
string -> @selector(..) or TextMarkerHelper)

https://codereview.chromium.org/2940923003/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_cocoa.mm:2690: int32_t
anchorId = manager->GetTreeData().sel_anchor_object_id;
(self review: convert to hacker_case)

https://codereview.chromium.org/2940923003/diff/40001/ui/accessibility/platfo...
File ui/accessibility/platform/text_marker_helper_mac.h (right):

https://codereview.chromium.org/2940923003/diff/40001/ui/accessibility/platfo...
ui/accessibility/platform/text_marker_helper_mac.h:34: class AX_EXPORT
PositionFactory {
(self review: comment)

https://codereview.chromium.org/2940923003/diff/40001/ui/accessibility/platfo...
ui/accessibility/platform/text_marker_helper_mac.h:39: virtual
std::unique_ptr<AXPositionBase> GetRoot() const = 0;
(self review: these too)

https://codereview.chromium.org/2940923003/diff/40001/ui/accessibility/platfo...
ui/accessibility/platform/text_marker_helper_mac.h:48: @interface
TextMarkerHelperMac : NSObject
(self review: comment)

Powered by Google App Engine
This is Rietveld 408576698