[Media Controls] Prevent fullscreen orientation lock rotate glitch

[Media Controls] Prevent fullscreen orientation lock rotate glitch

When both chrome://flags/#video-rotate-to-fullscreen and
chrome://flags/#video-fullscreen-orientation-lock are enabled, pressing
the fullscreen button then rotating the device to the opposite
orientation than the one that was locked to could result in jank or
accidentally exiting fullscreen. This patch works around those problems.

BUG=728145
Review-Url: https://codereview.chromium.org/2919513002
Cr-Commit-Position: refs/heads/master@{#479715}
Committed: https://chromium.googlesource.com/chromium/src/+/eeb22bd5bbaa417f1265e1fa596321d74d5e7f1e

[johnme, 2017-05-31 14:13:00]

johnme@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-05-31 20:18:37]

lgtm

https://codereview.chromium.org/2919513002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp
(right):

https://codereview.chromium.org/2919513002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp:1367:
testing::RunDelayedTasks(kUnlockDelayMs - 249);
Maybe you could harden this test by using `kUnlockDelayMs/2` above and here. You
can drop a +1 so you don't need to worry about rounding. Here, you take the risk
to fail when `kUnlockDelayMs` becomes lower than 250.

[johnme, 2017-06-01 17:21:57]

Addressed comment - thanks!

https://codereview.chromium.org/2919513002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp
(right):

https://codereview.chromium.org/2919513002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp:1367:
testing::RunDelayedTasks(kUnlockDelayMs - 249);
On 2017/05/31 20:18:37, mlamouri wrote:
> Maybe you could harden this test by using `kUnlockDelayMs/2` above and here.
You
> can drop a +1 so you don't need to worry about rounding. Here, you take the
risk
> to fail when `kUnlockDelayMs` becomes lower than 250.

If kUnlockDelayMs becomes lower than 250 (or at least 201), then the test should
fail, since empirically the race condition does sometimes occur when
kUnlockDelayMs is 200. I made the comments clearer.

[johnme, 2017-06-15 13:47:04]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-06-15 13:47:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2919513002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-15 13:47:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 14:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 14:49:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[johnme, 2017-06-15 15:07:09]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2017-06-15 15:07:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 15:44:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497539229531880,
"parent_rev": "b674b355a83fe5d12a0dd883818aaebdd35006bd", "commit_rev":
"eeb22bd5bbaa417f1265e1fa596321d74d5e7f1e"}

[commit-bot: I haz the power, 2017-06-15 15:44:18]

Description was changed from

==========
[Media Controls] Prevent fullscreen orientation lock rotate glitch

When both chrome://flags/#video-rotate-to-fullscreen and
chrome://flags/#video-fullscreen-orientation-lock are enabled, pressing
the fullscreen button then rotating the device to the opposite
orientation than the one that was locked to could result in jank or
accidentally exiting fullscreen. This patch works around those problems.

BUG=728145
==========

to

==========
[Media Controls] Prevent fullscreen orientation lock rotate glitch

When both chrome://flags/#video-rotate-to-fullscreen and
chrome://flags/#video-fullscreen-orientation-lock are enabled, pressing
the fullscreen button then rotating the device to the opposite
orientation than the one that was locked to could result in jank or
accidentally exiting fullscreen. This patch works around those problems.

BUG=728145

Review-Url: https://codereview.chromium.org/2919513002
Cr-Commit-Position: refs/heads/master@{#479715}
Committed:
https://chromium.googlesource.com/chromium/src/+/eeb22bd5bbaa417f1265e1fa5963...
==========

[commit-bot: I haz the power, 2017-06-15 15:44:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eeb22bd5bbaa417f1265e1fa5963...