Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2936413002: [Media Controls] Add UMA for rotate-to-fullscreen feature (Closed)

Created:
3 years, 6 months ago by johnme
Modified:
3 years, 6 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Controls] Add UMA for rotate-to-fullscreen feature Measures how often rotate-to-fullscren enters or exits fullscreen: - Media.Video.RotateToFullscreen.Enter - Media.Video.RotateToFullscreen.Exit and whether the screen orientation is allowed to rotate by the user: - Media.Video.FullscreenOrientationLock.AutoRotateEnabled BUG=713703 Review-Url: https://codereview.chromium.org/2936413002 Cr-Commit-Position: refs/heads/master@{#480105} Committed: https://chromium.googlesource.com/chromium/src/+/ce63450732e98d6e1341a97383dc7384cddac1f3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegate.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +14 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
johnme
3 years, 6 months ago (2017-06-15 17:23:29 UTC) #2
Ilya Sherman
Metrics LGTM % a comment: https://codereview.chromium.org/2936413002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2936413002/diff/1/tools/metrics/histograms/histograms.xml#newcode30027 tools/metrics/histograms/histograms.xml:30027: + orientation may still ...
3 years, 6 months ago (2017-06-15 19:50:52 UTC) #3
mlamouri (slow - plz ping)
lgtm with isherman@'s comment applied.
3 years, 6 months ago (2017-06-16 09:30:28 UTC) #4
johnme
Addressed review comment - thanks :) https://codereview.chromium.org/2936413002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2936413002/diff/1/tools/metrics/histograms/histograms.xml#newcode30027 tools/metrics/histograms/histograms.xml:30027: + orientation may ...
3 years, 6 months ago (2017-06-16 16:09:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936413002/20001
3 years, 6 months ago (2017-06-16 16:09:41 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 18:24:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce63450732e98d6e1341a97383dc...

Powered by Google App Engine
This is Rietveld 408576698