[WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list

[WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list

This CL changes needless two-way bindings to one way bindings on:
dom-if if=""; dom-repeat items=""; and iron-list items="". Also includes
a typo fix and missing quotes on an items="".

(code health)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2895723002
Cr-Commit-Position: refs/heads/master@{#473312}
Committed: https://chromium.googlesource.com/chromium/src/+/851068e36242e9f1903e220098de8beaef4f430a

[dschuyler, 2017-05-19 19:15:06]

Description was changed from

==========
[WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list

This CL changes needless two-way bindings to one way bindings on:
dom-if if=""; dom-repeat items=""; and iron-list items="". Also includes
a typo fix and missing quotes on an items="".

(code health)
BUG=None
==========

to

==========
[WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list

This CL changes needless two-way bindings to one way bindings on:
dom-if if=""; dom-repeat items=""; and iron-list items="". Also includes
a typo fix and missing quotes on an items="".

(code health)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-05-19 19:15:08]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 19:15:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-19 19:18:48]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2017-05-19 19:18:49]

Please help me by giving this an extra careful eye -- I'm not sure if I've hit
each change in my testing (the changes are spread out). Unless I made a typo, I
believe the changes are safe.

[dpapad, 2017-05-19 19:35:20]

LGTM. The changes from {{}} to [[]] in this CL seem safe.

https://codereview.chromium.org/2895723002/diff/1/chrome/test/data/webui/cr_e...
File chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js (right):

https://codereview.chromium.org/2895723002/diff/1/chrome/test/data/webui/cr_e...
chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js:21:
<iron-list scroll-target="container" items="[[items]]">
Was this caught by a PRESUBMIT? I recall that we added such a check a while ago,
but maybe only recently is being applied to test files?

[dschuyler, 2017-05-19 19:37:10]

https://codereview.chromium.org/2895723002/diff/1/chrome/test/data/webui/cr_e...
File chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js (right):

https://codereview.chromium.org/2895723002/diff/1/chrome/test/data/webui/cr_e...
chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js:21:
<iron-list scroll-target="container" items="[[items]]">
On 2017/05/19 19:35:19, dpapad wrote:
> Was this caught by a PRESUBMIT? I recall that we added such a check a while
ago,
> but maybe only recently is being applied to test files?

It wasn't. I was grepping for issues (just lookin' for trouble) and found it.
The presubmit may need a touch-up or config change(?)

[commit-bot: I haz the power, 2017-05-19 20:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:50:18]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-05-19 20:53:06]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:54:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:01:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495227186912610, "parent_rev":
"508534a90769468c845e0f0438fbcb4f4fe38d51", "commit_rev":
"9c85d209a6db821b86e967009c35d10dbcdf3e2d"}

[commit-bot: I haz the power, 2017-05-19 21:01:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495227186912610, "parent_rev":
"28d2a16306ed4423840becef6cfc38ca8763adfb", "commit_rev":
"851068e36242e9f1903e220098de8beaef4f430a"}

[commit-bot: I haz the power, 2017-05-19 21:01:42]

Description was changed from

==========
[WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list

This CL changes needless two-way bindings to one way bindings on:
dom-if if=""; dom-repeat items=""; and iron-list items="". Also includes
a typo fix and missing quotes on an items="".

(code health)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list

This CL changes needless two-way bindings to one way bindings on:
dom-if if=""; dom-repeat items=""; and iron-list items="". Also includes
a typo fix and missing quotes on an items="".

(code health)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2895723002
Cr-Commit-Position: refs/heads/master@{#473312}
Committed:
https://chromium.googlesource.com/chromium/src/+/851068e36242e9f1903e220098de...
==========

[commit-bot: I haz the power, 2017-05-19 21:01:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/851068e36242e9f1903e220098de...