Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2895723002: [WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by dschuyler
Modified:
2 months, 1 week ago
Reviewers:
dpapad
CC:
alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dbeam+watch-downloads_chromium.org, dbeam+watch-history_chromium.org, David Trainor- moved to gerrit, Patrick Dubroy, jam, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list This CL changes needless two-way bindings to one way bindings on: dom-if if=""; dom-repeat items=""; and iron-list items="". Also includes a typo fix and missing quotes on an items="". (code health) BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2895723002 Cr-Commit-Position: refs/heads/master@{#473312} Committed: https://chromium.googlesource.com/chromium/src/+/851068e36242e9f1903e220098de8beaef4f430a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/resources/chromeos/emulator/battery_settings.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-bookmarks-content/viewer-bookmarks-content.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js View 1 chunk +1 line, -1 line 2 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 15 (10 generated)
dschuyler
Please help me by giving this an extra careful eye -- I'm not sure if ...
2 months, 1 week ago (2017-05-19 19:18:49 UTC) #5
dpapad
LGTM. The changes from {{}} to [[]] in this CL seem safe. https://codereview.chromium.org/2895723002/diff/1/chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js File chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js ...
2 months, 1 week ago (2017-05-19 19:35:20 UTC) #6
dschuyler
https://codereview.chromium.org/2895723002/diff/1/chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js File chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js (right): https://codereview.chromium.org/2895723002/diff/1/chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js#newcode21 chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js:21: <iron-list scroll-target="container" items="[[items]]"> On 2017/05/19 19:35:19, dpapad wrote: > ...
2 months, 1 week ago (2017-05-19 19:37:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895723002/1
2 months, 1 week ago (2017-05-19 20:54:02 UTC) #11
commit-bot: I haz the power
2 months, 1 week ago (2017-05-19 21:01:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/851068e36242e9f1903e220098de...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld a45af40d5