chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html - Issue 2895723002: [WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

Issue 2895723002: [WebUI] use one-way Polymer binding on dom-if, dom-repeat, and iron-list (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_history/history_list.html ('k') | chrome/browser/resources/pdf/elements/viewer-bookmarks-content/viewer-bookmarks-content.html » ('j') | chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

diff --git a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

index 1583c92c6d7efb358abe8645cbdc3ee12e252f16..44a609e5065d2b763aa27a90a4785565753bed2c 100644

--- a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

+++ b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

@@ -21,7 +21,7 @@

paper-ripple {

/* Allowing the ripple to capture pointer events prevents a focus

* rectangle for showing up for clicks, while still allowing it with

- * tab-navigation. This undoes a paper-ripple bugfix aimed at

+ * tab-navigation. This undoes a paper-ripple bug fix aimed at

* non-Chrome browsers. TODO(tsergeant): Improve focus in

* viewer-bookmark so this can be removed (https://crbug.com/5448190).

@@ -62,8 +62,8 @@

</div>

<!-- dom-if will stamp the complex bookmark tree lazily as individual nodes

are opened. -->

- <template is="dom-if" if="{{childrenShown}}" id="sub-bookmarks">

- <template is="dom-repeat" items="{{bookmark.children}}">

+ <template is="dom-if" if="[[childrenShown]]" id="sub-bookmarks">

+ <template is="dom-repeat" items="[[bookmark.children]]">

<viewer-bookmark bookmark="{{item}}" depth="{{childDepth}}">

</viewer-bookmark>

</template>