Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/215261) ios-simulator-xcode-clang on ...
3 years, 7 months ago
(2017-05-19 21:18:57 UTC)
#9
https://codereview.chromium.org/2895473005/diff/40001/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc File chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc (right): https://codereview.chromium.org/2895473005/diff/40001/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc#newcode105 chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc:105: view_parent->GetViewByID(autofill::CREDIT_CARD_EXP_MONTH)); Does this break? You're not adding the offset? ...
3 years, 7 months ago
(2017-05-19 21:27:01 UTC)
#10
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495470645718310, "parent_rev": "c1fe1f6a3c9e8e165f915a3f3545a894b6b90abe", "commit_rev": "af7b1e7969eb07a91bc75accb5e9af2daffd4790"}
3 years, 7 months ago
(2017-05-22 17:15:43 UTC)
#25
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495470645718310,
"parent_rev": "c1fe1f6a3c9e8e165f915a3f3545a894b6b90abe", "commit_rev":
"af7b1e7969eb07a91bc75accb5e9af2daffd4790"}
commit-bot: I haz the power
Description was changed from ========== [Payments] Have expiration date be on the same line in ...
3 years, 7 months ago
(2017-05-22 17:15:56 UTC)
#26
Message was sent while issue was closed.
Description was changed from
==========
[Payments] Have expiration date be on the same line in CC editor
Fields are now validated together and will appear invalid at the same
time if the date is invalid. Requires creating a special validation
delegate.
BUG=724584
TEST=browser_tests
==========
to
==========
[Payments] Have expiration date be on the same line in CC editor
Fields are now validated together and will appear invalid at the same
time if the date is invalid. Requires creating a special validation
delegate.
BUG=724584
TEST=browser_tests
Review-Url: https://codereview.chromium.org/2895473005
Cr-Commit-Position: refs/heads/master@{#473607}
Committed:
https://chromium.googlesource.com/chromium/src/+/af7b1e7969eb07a91bc75accb5e9...
==========
commit-bot: I haz the power
Committed patchset #5 (id:100001) as https://chromium.googlesource.com/chromium/src/+/af7b1e7969eb07a91bc75accb5e9af2daffd4790
3 years, 7 months ago
(2017-05-22 17:15:57 UTC)
#27
Issue 2895473005: [Payments] Have expiration date be on the same line in CC editor
(Closed)
Created 3 years, 7 months ago by Mathieu
Modified 3 years, 7 months ago
Reviewers: anthonyvd
Base URL:
Comments: 26