Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h

Issue 2895473005: [Payments] Have expiration date be on the same line in CC editor (Closed)
Patch Set: addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
diff --git a/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h b/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
index 3bfd7c704711e7a7824858caa47aee4069e3ee04..5ee2d6bc1a2eca7843d368fdd658cd7bdd02b6c0 100644
--- a/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
+++ b/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
@@ -65,10 +65,6 @@ enum class DialogViewID : int {
// unique at the scope of the parent row.
CHECKMARK_VIEW,
- // Used to label the error labels with an offset, which gets added to
- // the Autofill type value they represent (for tests).
- ERROR_LABEL_OFFSET,
-
// The CVC text field in the unmask sheet.
CVC_PROMPT_TEXT_FIELD,
CVC_ERROR_LABEL,
@@ -81,6 +77,14 @@ enum class DialogViewID : int {
// The combobox to choose a billing address to associate to a credit card.
CREDIT_CARD_BILLING_ADDRESS,
+
+ // NOTE: Keep these values last.
+ // Used to offset the IDs of input fields, which gets added to the Autofill
+ // type value they represent.
+ INPUT_FIELD_TYPE_OFFSET,
+ // Used to label the error labels with an offset, which gets added to
+ // the Autofill type value they represent.
+ ERROR_LABEL_OFFSET = INPUT_FIELD_TYPE_OFFSET + autofill::MAX_VALID_FIELD_TYPE,
};
} // namespace payments

Powered by Google App Engine
This is Rietveld 408576698