Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2893843002: input: Remove now dead code. (Closed)

Created:
6 months ago by sadrul
Modified:
6 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

input: Remove now dead code. With the updated code for dispatching synthesized input events during telemetry tests (crrev.com/472595), InputRouterClient::DidFlush() and InputRouter::RequestNotificationWhenFlushed() are no longer needed. So remove the associated code and tests. BUG=722921 Review-Url: https://codereview.chromium.org/2893843002 Cr-Commit-Position: refs/heads/master@{#473361} Committed: https://chromium.googlesource.com/chromium/src/+/b8213899699b5b98f778b5a418d889fa25dc96dc

Patch Set 1 #

Patch Set 2 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -185 lines) Patch
M content/browser/renderer_host/input/input_router.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/input_router_client.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 5 chunks +0 lines, -20 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_perftest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 2 chunks +0 lines, -123 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.h View 3 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.cc View 3 chunks +1 line, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
sadrul
6 months ago (2017-05-19 18:34:43 UTC) #7
dtapuska
On 2017/05/19 18:34:43, sadrul wrote: lgtm
6 months ago (2017-05-19 18:39:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893843002/20001
6 months ago (2017-05-19 20:15:49 UTC) #13
commit-bot: I haz the power
6 months ago (2017-05-19 22:21:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b8213899699b5b98f778b5a418d8...

Powered by Google App Engine
This is Rietveld efc10ee0f