Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: content/browser/renderer_host/input/input_router_impl.cc

Issue 2893843002: input: Remove now dead code. (Closed)
Patch Set: tot merge Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/input_router_impl.cc
diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc
index c3ff486accc190c74093ccf8206efdc66587cff0..f01b8144bfc4d5c75af033f57c3dbcb9a0e882bb 100644
--- a/content/browser/renderer_host/input/input_router_impl.cc
+++ b/content/browser/renderer_host/input/input_router_impl.cc
@@ -84,7 +84,6 @@ InputRouterImpl::InputRouterImpl(IPC::Sender* sender,
select_message_pending_(false),
move_caret_pending_(false),
current_ack_source_(ACK_SOURCE_NONE),
- flush_requested_(false),
active_renderer_fling_count_(0),
touch_scroll_started_sent_(false),
wheel_event_queue_(this,
@@ -231,11 +230,6 @@ void InputRouterImpl::NotifySiteIsMobileOptimized(bool is_mobile_optimized) {
touch_event_queue_->SetIsMobileOptimizedSite(is_mobile_optimized);
}
-void InputRouterImpl::RequestNotificationWhenFlushed() {
- flush_requested_ = true;
- SignalFlushedIfNecessary();
-}
-
bool InputRouterImpl::HasPendingEvents() const {
return !touch_event_queue_->Empty() || !gesture_event_queue_.empty() ||
!key_queue_.empty() || !mouse_move_queue_.empty() ||
@@ -518,7 +512,6 @@ void InputRouterImpl::OnDidStopFlinging() {
// renderer, not from any other consumers. Consequently, the GestureEventQueue
// cannot use this bookkeeping for logic like tap suppression.
--active_renderer_fling_count_;
- SignalFlushedIfNecessary();
client_->DidStopFlinging();
}
@@ -555,8 +548,6 @@ void InputRouterImpl::ProcessInputEventAck(WebInputEvent::Type event_type,
} else if (event_type != WebInputEvent::kUndefined) {
ack_handler_->OnUnexpectedEventAck(InputAckHandler::BAD_ACK_MESSAGE);
}
-
- SignalFlushedIfNecessary();
}
void InputRouterImpl::ProcessKeyboardAck(blink::WebInputEvent::Type type,
@@ -632,17 +623,6 @@ void InputRouterImpl::UpdateTouchAckTimeoutEnabled() {
touch_event_queue_->SetAckTimeoutEnabled(touch_ack_timeout_enabled);
}
-void InputRouterImpl::SignalFlushedIfNecessary() {
- if (!flush_requested_)
- return;
-
- if (HasPendingEvents())
- return;
-
- flush_requested_ = false;
- client_->DidFlush();
-}
-
void InputRouterImpl::SetFrameTreeNodeId(int frameTreeNodeId) {
frame_tree_node_id_ = frameTreeNodeId;
}

Powered by Google App Engine
This is Rietveld 408576698