Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2852893002:
Made RefPtr constructor only accept PassRefPtr rvalues. (Closed)
DescriptionMade RefPtr constructor only accept PassRefPtr rvalues.
Changed RefPtr constructor PassRefPtr argument from const lvalue to
rvalue so that PassRefPtr objects cannot be copied into RefPtr
objects. PassRefPtr objects being copied into RefPtr objects represent
places that would introduce ref churn in future patches when PassRefPtr
objects will be replaced with RefPtr objects.
All instances of PassRefPtr to RefPtr copies have been
removed from the code base, and this change prevents new instances from
being added.
BUG=494719
Review-Url: https://codereview.chromium.org/2852893002
Cr-Commit-Position: refs/heads/master@{#471200}
Committed: https://chromium.googlesource.com/chromium/src/+/7e967b1611c47d7a0ee53e2c921201cc1509d5da
Patch Set 1 #Patch Set 2 : added move wrap #
Depends on Patchset: Messages
Total messages: 28 (17 generated)
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bugsnash@chromium.org changed reviewers: + haraken@chromium.org, yutak@chromium.org
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Looks like I need to make some changes in unit tests before this one can land
The change itself LGTM yay! This will be still LGTM if you just need to apply more std::move()s to fix build.
added branch dependency
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bugsnash@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, yutak@chromium.org Link to the patchset: https://codereview.chromium.org/2852893002/#ps20001 (title: "added move wrap")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by bugsnash@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bugsnash@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494551306137280,
"parent_rev": "872e2db0bbc390dc17223d85a48581549b8a0836", "commit_rev":
"7e967b1611c47d7a0ee53e2c921201cc1509d5da"}
Message was sent while issue was closed.
Description was changed from ========== Made RefPtr constructor only accept PassRefPtr rvalues. Changed RefPtr constructor PassRefPtr argument from const lvalue to rvalue so that PassRefPtr objects cannot be copied into RefPtr objects. PassRefPtr objects being copied into RefPtr objects represent places that would introduce ref churn in future patches when PassRefPtr objects will be replaced with RefPtr objects. All instances of PassRefPtr to RefPtr copies have been removed from the code base, and this change prevents new instances from being added. BUG=494719 ========== to ========== Made RefPtr constructor only accept PassRefPtr rvalues. Changed RefPtr constructor PassRefPtr argument from const lvalue to rvalue so that PassRefPtr objects cannot be copied into RefPtr objects. PassRefPtr objects being copied into RefPtr objects represent places that would introduce ref churn in future patches when PassRefPtr objects will be replaced with RefPtr objects. All instances of PassRefPtr to RefPtr copies have been removed from the code base, and this change prevents new instances from being added. BUG=494719 Review-Url: https://codereview.chromium.org/2852893002 Cr-Commit-Position: refs/heads/master@{#471200} Committed: https://chromium.googlesource.com/chromium/src/+/7e967b1611c47d7a0ee53e2c9212... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7e967b1611c47d7a0ee53e2c9212... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
