DescriptionRemoved PassRefPtr to RefPtr copies from unit tests.
All instances of PassRefPtr objects being copied into RefPtr objects
need to be wrapped in std::move to avoid introducing ref churn in
future changes when all PassRefPtr objects will be replaced with RefPtr
objects. Some cases create a local RefPtr just to copy the PassRefPtr
argument into; in these cases a std::move wrap doesn't make sense as it
would result in a final state where a RefPtr argument is moved into a
local RefPtr for no reason. So to handle these cases I have converted
the PassRefPtr arguments to RefPtr in advance, and removed the local
RefPtr argument, instead using the passed RefPtr throughout the
methods.
Changed include
- added std::move wraps to PassReftr objects to force a move
- removed local RefPtr objects where PassRefPtr arguments are copied
into them, instead change PassRefPtr argument to RefPtr that is
directly used.
BUG=494719
Review-Url: https://codereview.chromium.org/2870543002
Cr-Commit-Position: refs/heads/master@{#470240}
Committed: https://chromium.googlesource.com/chromium/src/+/aa79e549a918ff2530db858e281eb9f1515c2d5b
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 13 (8 generated)
|