Fix behaviour of shadow interpolation with mismatched list lengths

Fix behaviour of shadow interpolation with mismatched list lengths

For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.

The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.

Spec: https://www.w3.org/TR/css3-transitions/#animatable-types

This change adds the "padding" behaviour to list interpolation and
composition and updates our shadow animation test cases to match
spec behaviour.

BUG=713674
Review-Url: https://codereview.chromium.org/2844213002
Cr-Commit-Position: refs/heads/master@{#470205}
Committed: https://chromium.googlesource.com/chromium/src/+/4aaaf95a33ef49f61476ca1f3699700fa7ea3fe8

[alancutter (OOO until 2018), 2017-04-27 05:54:22]

Description was changed from

==========
Fix behaviour of shadow interpolation with mismatched list lengths

BUG=713674
==========

to

==========
Fix behaviour of shadow interpolation with mismatched list lengths

For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.

The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.

Spec: https://www.w3.org/TR/css3-transitions/#animatable-types

This change adds the "padding" behaviour to list interpolation and
composition and updates our test cases to match spec behaviour.

BUG=713674
==========

[alancutter (OOO until 2018), 2017-04-27 05:54:22]

alancutter@chromium.org changed reviewers:
+ shend@chromium.org

[shend, 2017-04-27 06:07:49]

lgtm with nits.

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html
(right):

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26:
to: 'green 20px 20px 20px',
What are these changes for?

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h
(right):

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h:26: enum
LengthMatchingStrategy { kLowestCommonMultiple, kPadToLargest };
Should the enum value name indicate that it's a strategy? e.g.
kMatchingStrategyLowestCommonMultiple?

[alancutter (OOO until 2018), 2017-04-27 07:08:51]

Description was changed from

==========
Fix behaviour of shadow interpolation with mismatched list lengths

For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.

The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.

Spec: https://www.w3.org/TR/css3-transitions/#animatable-types

This change adds the "padding" behaviour to list interpolation and
composition and updates our test cases to match spec behaviour.

BUG=713674
==========

to

==========
Fix behaviour of shadow interpolation with mismatched list lengths

For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.

The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.

Spec: https://www.w3.org/TR/css3-transitions/#animatable-types

This change adds the "padding" behaviour to list interpolation and
composition and updates our shadow animation test cases to match
spec behaviour.

BUG=713674
==========

[alancutter (OOO until 2018), 2017-04-27 07:09:22]

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html
(right):

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26:
to: 'green 20px 20px 20px',
On 2017/04/27 at 06:07:49, shend wrote:
> What are these changes for?

Oops, forgot I did these.
They're to make the input values consistent with the output values where the
colour is on the left to make it easier to read. Can remove if too unrelated.

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h
(right):

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h:26: enum
LengthMatchingStrategy { kLowestCommonMultiple, kPadToLargest };
On 2017/04/27 at 06:07:49, shend wrote:
> Should the enum value name indicate that it's a strategy? e.g.
kMatchingStrategyLowestCommonMultiple?

Made it an enum class.

[shend, 2017-04-27 07:30:51]

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html
(right):

https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26:
to: 'green 20px 20px 20px',
On 2017/04/27 at 07:09:22, alancutter wrote:
> On 2017/04/27 at 06:07:49, shend wrote:
> > What are these changes for?
> 
> Oops, forgot I did these.
> They're to make the input values consistent with the output values where the
colour is on the left to make it easier to read. Can remove if too unrelated.

Nah it seems fine to keep it.

[alancutter (OOO until 2018), 2017-04-28 23:42:25]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-04-28 23:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2844213002/#ps40001
(title: "enumClass")

[commit-bot: I haz the power, 2017-04-28 23:43:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 23:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:43:18]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[alancutter (OOO until 2018), 2017-04-29 23:27:48]

alancutter@chromium.org changed reviewers:
+ suzyh@chromium.org

[alancutter (OOO until 2018), 2017-04-29 23:27:49]

+suzyh for OWNERS review.

[suzyh_UTC10 (ex-contributor), 2017-05-01 00:23:55]

rs lgtm

https://codereview.chromium.org/2844213002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html
(right):

https://codereview.chromium.org/2844213002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26:
to: 'green 20px 20px 20px',
Is colour-at-end still a valid value here? If so, do we have tests to show that
we handle it correctly?

[alancutter (OOO until 2018), 2017-05-08 06:36:42]

https://codereview.chromium.org/2844213002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html
(right):

https://codereview.chromium.org/2844213002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26:
to: 'green 20px 20px 20px',
On 2017/05/01 at 00:23:55, suzyh_UTC10 wrote:
> Is colour-at-end still a valid value here? If so, do we have tests to show
that we handle it correctly?

I'll add one back in, good call.

[alancutter (OOO until 2018), 2017-05-08 06:36:47]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-05-08 06:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org,
shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2844213002/#ps60001
(title: "colourcolorcolour")

[commit-bot: I haz the power, 2017-05-08 06:37:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 08:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 08:50:49]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2017-05-08 23:47:39]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-05-08 23:47:40]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org,
shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2844213002/#ps80001
(title: "Revert transition test to old behaviour")

[commit-bot: I haz the power, 2017-05-09 00:07:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:26:15]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2017-05-09 02:39:30]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-05-09 02:40:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:29:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494297570535110,
"parent_rev": "08ce463ab55e4d777f21f394a78cefaaa5a777f1", "commit_rev":
"4aaaf95a33ef49f61476ca1f3699700fa7ea3fe8"}

[commit-bot: I haz the power, 2017-05-09 04:29:29]

Description was changed from

==========
Fix behaviour of shadow interpolation with mismatched list lengths

For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.

The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.

Spec: https://www.w3.org/TR/css3-transitions/#animatable-types

This change adds the "padding" behaviour to list interpolation and
composition and updates our shadow animation test cases to match
spec behaviour.

BUG=713674
==========

to

==========
Fix behaviour of shadow interpolation with mismatched list lengths

For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.

The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.

Spec: https://www.w3.org/TR/css3-transitions/#animatable-types

This change adds the "padding" behaviour to list interpolation and
composition and updates our shadow animation test cases to match
spec behaviour.

BUG=713674

Review-Url: https://codereview.chromium.org/2844213002
Cr-Commit-Position: refs/heads/master@{#470205}
Committed:
https://chromium.googlesource.com/chromium/src/+/4aaaf95a33ef49f61476ca1f3699...
==========

[commit-bot: I haz the power, 2017-05-09 04:29:30]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4aaaf95a33ef49f61476ca1f3699...