third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp - Issue 2844213002: Fix behaviour of shadow interpolation with mismatched list lengths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

Issue 2844213002: Fix behaviour of shadow interpolation with mismatched list lengths (Closed)

Patch Set: Revert transition test to old behaviour Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

index 36d4ca3be72e98bcc0ef5fd84e827e6d0afc3435..d666851eb7f8b112b69e433ab1b032f64734cf2f 100644

--- a/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

@@ -124,6 +124,7 @@ PairwiseInterpolationValue CSSLengthListInterpolationType::MaybeMergeSingles(

InterpolationValue&& end) const {

return ListInterpolationFunctions::MaybeMergeSingles(

std::move(start), std::move(end),

+ ListInterpolationFunctions::LengthMatchingStrategy::kLowestCommonMultiple,

LengthInterpolationFunctions::MergeSingles);

}

@@ -144,6 +145,7 @@ void CSSLengthListInterpolationType::Composite(

double interpolation_fraction) const {

ListInterpolationFunctions::Composite(

underlying_value_owner, underlying_fraction, *this, value,

+ ListInterpolationFunctions::LengthMatchingStrategy::kLowestCommonMultiple,

LengthInterpolationFunctions::NonInterpolableValuesAreCompatible,

LengthInterpolationFunctions::Composite);

}