Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2840933003: Shows snackbar in translate infobar, after certain user actions. (Closed)

Created:
3 years, 8 months ago by ramyasharma
Modified:
3 years, 7 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Shows snackbar in translate infobar, after certain user actions. CL#2 Plumbs through snackbar manager from Infobar container to TranslateCompactInfobar, and shows a snackbar on actions like always / never translate. BUG=713514 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2840933003 Cr-Commit-Position: refs/heads/master@{#468917} Committed: https://chromium.googlesource.com/chromium/src/+/48808f1acfda5746d21186fc83fbc60ffe0646d9

Patch Set 1 #

Total comments: 7

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Patch Set 4 #

Messages

Total messages: 96 (82 generated)
ramyasharma
3 years, 8 months ago (2017-04-26 08:00:07 UTC) #7
gone
https://codereview.chromium.org/2840933003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java (right): https://codereview.chromium.org/2840933003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java#newcode168 chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:168: } This won't work if the tab is sent ...
3 years, 8 months ago (2017-04-26 17:27:02 UTC) #11
ramyasharma
Thanks Dan, PTAL? https://codereview.chromium.org/2840933003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java (right): https://codereview.chromium.org/2840933003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java#newcode168 chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:168: } On 2017/04/26 17:27:02, slow (dfalcantara) ...
3 years, 7 months ago (2017-04-27 08:03:12 UTC) #18
gone
https://codereview.chromium.org/2840933003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java (right): https://codereview.chromium.org/2840933003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java#newcode168 chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:168: } On 2017/04/27 08:03:11, ramyasharma wrote: > On 2017/04/26 ...
3 years, 7 months ago (2017-04-27 18:48:58 UTC) #21
ramyasharma
Thanks Dan. PTAL? https://codereview.chromium.org/2840933003/diff/120001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java (right): https://codereview.chromium.org/2840933003/diff/120001/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java#newcode115 chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:115: if (activity != null && activity ...
3 years, 7 months ago (2017-04-28 06:35:59 UTC) #31
gone
lgtm
3 years, 7 months ago (2017-04-30 02:12:15 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840933003/180001
3 years, 7 months ago (2017-05-01 07:42:49 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/424254) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-01 07:45:38 UTC) #41
ramyasharma
asvitkine@ for histograms.xml
3 years, 7 months ago (2017-05-02 06:15:31 UTC) #57
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-02 15:36:29 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840933003/240001
3 years, 7 months ago (2017-05-02 23:06:55 UTC) #64
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/260461)
3 years, 7 months ago (2017-05-03 01:04:04 UTC) #66
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840933003/420001
3 years, 7 months ago (2017-05-03 08:16:07 UTC) #93
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 08:20:19 UTC) #96
Message was sent while issue was closed.
Committed patchset #4 (id:420001) as
https://chromium.googlesource.com/chromium/src/+/48808f1acfda5746d21186fc83fb...

Powered by Google App Engine
This is Rietveld 408576698