Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2840933003: Shows snackbar in translate infobar, after certain user actions. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
index aad278b28fb3e344ea29e6e5c1bfc8ec3b25eb4b..4d7592fe35818963c08b398af79e2b83bc077c37 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
@@ -15,6 +15,7 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.infobar.translate.TranslateMenu;
import org.chromium.chrome.browser.infobar.translate.TranslateMenuHelper;
import org.chromium.chrome.browser.infobar.translate.TranslateTabLayout;
+import org.chromium.chrome.browser.snackbar.Snackbar;
import org.chromium.chrome.browser.widget.TintedImageButton;
import org.chromium.ui.widget.Toast;
@@ -200,10 +201,6 @@ class TranslateCompactInfoBar extends InfoBar
}
}
- private void showSnackbar(int snackbarType) {
- // TODO(ramyasharma): Show snackbar.
- }
-
@Override
public void onTargetMenuItemClicked(String code) {
// Reset target code in both UI and native.
@@ -228,6 +225,31 @@ class TranslateCompactInfoBar extends InfoBar
}
}
+ private void showSnackbar(int snackbarType) {
+ if (snackbarType == TranslateSnackbarType.NEVER_TRANSLATE) {
+ createAndShowSnackbar(getContext().getString(R.string.translate_snackbar_language_never,
+ mOptions.sourceLanguageName()),
+ Snackbar.UMA_TRANSLATE_NEVER);
+ } else if (snackbarType == TranslateSnackbarType.ALWAYS_TRANSLATE) {
+ createAndShowSnackbar(
+ getContext().getString(R.string.translate_snackbar_always_translate,
+ mOptions.sourceLanguageName(), mOptions.targetLanguageName()),
+ Snackbar.UMA_TRANSLATE_ALWAYS);
+ } else if (snackbarType == TranslateSnackbarType.NEVER_TRANSLATE_SITE) {
+ createAndShowSnackbar(getContext().getString(R.string.translate_snackbar_site_never),
+ Snackbar.UMA_TRANSLATE_NEVER_SITE);
+ }
+ }
+
+ private void createAndShowSnackbar(String title, int type) {
+ if (getSnackbarManager() == null) {
+ return;
+ }
+ getSnackbarManager().showSnackbar(Snackbar.make(title, new TranslateSnackbarController(),
+ Snackbar.TYPE_NOTIFICATION, type)
+ .setSingleLine(false));
+ }
+
private native void nativeApplyStringTranslateOption(
long nativeTranslateCompactInfoBar, int option, String value);
private native void nativeApplyBoolTranslateOption(

Powered by Google App Engine
This is Rietveld 408576698