Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2840483002: Log the creation of Sign In related dialog boxes. (Closed)

Created:
3 years, 8 months ago by pdyson
Modified:
3 years, 7 months ago
Reviewers:
msw, jwd, msarda
CC:
asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, estade+watch_chromium.org, extensions-reviews_chromium.org, mathp+autofillwatch_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, tfarina, vabr+watchlistautofill_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Log the creation of Sign In related dialog boxes. BUG=705331 Review-Url: https://codereview.chromium.org/2840483002 Cr-Commit-Position: refs/heads/master@{#469264} Committed: https://chromium.googlesource.com/chromium/src/+/918928e65b775182d50ea33ac24d45e9501e7e82

Patch Set 1 #

Patch Set 2 : Removed files submitted in another cl. #

Patch Set 3 : Updated after feedback from Sign In team. #

Patch Set 4 : Add Sign In Email Confirmation. #

Total comments: 1

Patch Set 5 : change enum to SIGN_IN #

Patch Set 6 : All enums moved to separate file by another cl, need to sync. #

Patch Set 7 : correct enums in enums.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/ui/browser_dialogs.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/signin_view_controller.cc View 1 2 3 4 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_email_confirmation_dialog.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 41 (28 generated)
pdyson
3 years, 7 months ago (2017-04-28 00:41:01 UTC) #6
pdyson
msarda@, can you take a look at this?
3 years, 7 months ago (2017-05-01 00:09:31 UTC) #7
jwd
metrics LGTM
3 years, 7 months ago (2017-05-01 21:00:09 UTC) #8
msarda
LGTM with a enum entry change. https://codereview.chromium.org/2840483002/diff/60001/chrome/browser/ui/browser_dialogs.h File chrome/browser/ui/browser_dialogs.h (right): https://codereview.chromium.org/2840483002/diff/60001/chrome/browser/ui/browser_dialogs.h#newcode236 chrome/browser/ui/browser_dialogs.h:236: SIGN_IN_EXISTING_DATA = 27, ...
3 years, 7 months ago (2017-05-02 09:55:03 UTC) #9
pdyson
On 2017/05/02 at 09:55:03, msarda wrote: > LGTM with a enum entry change. > > ...
3 years, 7 months ago (2017-05-03 04:31:12 UTC) #10
pdyson
3 years, 7 months ago (2017-05-03 04:31:25 UTC) #11
pdyson
msw@ can you take a look at this? I've already got approval from msarda@ who ...
3 years, 7 months ago (2017-05-03 04:33:47 UTC) #13
msw
lgtm
3 years, 7 months ago (2017-05-03 17:30:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840483002/80001
3 years, 7 months ago (2017-05-04 01:25:36 UTC) #21
commit-bot: I haz the power
Failed to apply patch for tools/metrics/histograms/histograms.xml: While running git apply --index -3 -p1; error: patch ...
3 years, 7 months ago (2017-05-04 01:39:47 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840483002/100001
3 years, 7 months ago (2017-05-04 02:54:42 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840483002/120001
3 years, 7 months ago (2017-05-04 03:44:31 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 03:50:34 UTC) #41
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/918928e65b775182d50ea33ac24d...

Powered by Google App Engine
This is Rietveld 408576698