Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: chrome/browser/ui/signin_view_controller.cc

Issue 2840483002: Log the creation of Sign In related dialog boxes. (Closed)
Patch Set: correct enums in enums.xml Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_dialogs.h ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/signin_view_controller.cc
diff --git a/chrome/browser/ui/signin_view_controller.cc b/chrome/browser/ui/signin_view_controller.cc
index 6ca3c480574e19145151d0998d3cb3ec63687081..ea3bb66cd816d02ed0f8f5c367d42e95d814af5f 100644
--- a/chrome/browser/ui/signin_view_controller.cc
+++ b/chrome/browser/ui/signin_view_controller.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/signin_view_controller.h"
+#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/ui/signin_view_controller_delegate.h"
#include "components/signin/core/common/profile_management_switches.h"
@@ -24,6 +25,7 @@ void SigninViewController::ShowModalSignin(
signin_view_controller_delegate_ =
SigninViewControllerDelegate::CreateModalSigninDelegate(
this, mode, browser, access_point);
+ chrome::RecordDialogCreation(chrome::DialogIdentifier::SIGN_IN);
}
void SigninViewController::ShowModalSyncConfirmationDialog(Browser* browser) {
@@ -33,6 +35,8 @@ void SigninViewController::ShowModalSyncConfirmationDialog(Browser* browser) {
signin_view_controller_delegate_ =
SigninViewControllerDelegate::CreateSyncConfirmationDelegate(this,
browser);
+ chrome::RecordDialogCreation(
+ chrome::DialogIdentifier::SIGN_IN_SYNC_CONFIRMATION);
}
void SigninViewController::ShowModalSigninErrorDialog(Browser* browser) {
@@ -41,6 +45,7 @@ void SigninViewController::ShowModalSigninErrorDialog(Browser* browser) {
// is closed.
signin_view_controller_delegate_ =
SigninViewControllerDelegate::CreateSigninErrorDelegate(this, browser);
+ chrome::RecordDialogCreation(chrome::DialogIdentifier::SIGN_IN_ERROR);
}
void SigninViewController::CloseModalSignin() {
« no previous file with comments | « chrome/browser/ui/browser_dialogs.h ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698