content/browser/accessibility/browser_accessibility_win.cc - Issue 2833843005: Handling of different types of empty alt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 2833843005: Handling of different types of empty alt (Closed)

Patch Set: Ready to land Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index b87cb641b05d20d2cd57c94d12e016cfee2328f3..22410f8cb62a26edaf79b3c1d170d80200b50aa8 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -4285,9 +4285,6 @@ HRESULT BrowserAccessibilityWin::GetStringAttributeAsBstr(

if (!GetString16Attribute(attribute, &str))

return S_FALSE;

- if (str.empty())

- return S_FALSE;

*value_bstr = SysAllocString(str.c_str());

DCHECK(*value_bstr);