content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 2833843005: Handling of different types of empty alt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 2833843005: Handling of different types of empty alt (Closed)

Patch Set: Ready to land Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index a1685aee192d96b73f9b73c5c863d3175e4ebc5c..a1e12cfb4a719699e787889d5485f5da85d60c00 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -860,7 +860,7 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";

// Given an image where there's no other title, return the base part

// of the filename as the description.

if ([[self role] isEqualToString:NSAccessibilityImageRole]) {

- if (browserAccessibility_->HasStringAttribute(ui::AX_ATTR_NAME))

+ if (browserAccessibility_->HasExplicitlyEmptyName())

return @"";

if ([self titleUIElement])

return @"";