Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 2833843005: Handling of different types of empty alt (Closed)
Patch Set: Ready to land Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc
diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
index c6a9e1a23c17f2e0a823d9e0819553ec69aa5104..4520933976a66f81d9ddde452a3a698cd03af72b 100644
--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
@@ -59,10 +59,12 @@ class DumpAccessibilityTreeTest : public DumpAccessibilityTestBase {
void AddDefaultFilters(std::vector<Filter>* filters) override {
filters->push_back(Filter(base::ASCIIToUTF16("FOCUSABLE"), Filter::ALLOW));
filters->push_back(Filter(base::ASCIIToUTF16("READONLY"), Filter::ALLOW));
- filters->push_back(Filter(base::ASCIIToUTF16("name=*"), Filter::ALLOW));
filters->push_back(Filter(base::ASCIIToUTF16("roleDescription=*"),
Filter::ALLOW));
filters->push_back(Filter(base::ASCIIToUTF16("*=''"), Filter::DENY));
+ // After denying empty values, because we want to allow name=''
+ filters->push_back(
+ Filter(base::ASCIIToUTF16("name=*"), Filter::ALLOW_EMPTY));
}
void SetUpCommandLine(base::CommandLine* command_line) override {
@@ -1048,6 +1050,11 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityImgEmptyAlt) {
RunHtmlTest(FILE_PATH_LITERAL("img-empty-alt.html"));
}
+IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
+ AccessibilityImgLinkEmptyAlt) {
+ RunHtmlTest(FILE_PATH_LITERAL("img-link-empty-alt.html"));
+}
+
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityInPageLinks) {
RunHtmlTest(FILE_PATH_LITERAL("in-page-links.html"));
}
« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/renderer/accessibility/blink_ax_enum_conversion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698