Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(735)

Issue 2828353004: Remove HostSharedBitmapManager::AllocateSharedBitmapForChild (Closed)

Created:
10 months ago by hajimehoshi
Modified:
10 months ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostSharedBitmapManager::AllocateSharedBitmapForChild This CL removes HostSharedBitmapManager::AllocateSharedBitmapForChild that is not used anywhere except for unit tests. BUG=n/a TEST=components_unittests --gtest_filter=HostSharedBitmapManagerTest.* Review-Url: https://codereview.chromium.org/2828353004 Cr-Commit-Position: refs/heads/master@{#466379} Committed: https://chromium.googlesource.com/chromium/src/+/8a4dae0937f0db75532f6bad443826db4280f0ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -77 lines) Patch
M components/display_compositor/host_shared_bitmap_manager.h View 2 chunks +0 lines, -10 lines 0 comments Download
M components/display_compositor/host_shared_bitmap_manager.cc View 2 chunks +0 lines, -42 lines 0 comments Download
M components/display_compositor/host_shared_bitmap_manager_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hajimehoshi
PTAL
10 months ago (2017-04-21 12:05:35 UTC) #2
danakj
Thanks, LGTM
10 months ago (2017-04-21 15:17:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828353004/1
10 months ago (2017-04-21 17:25:06 UTC) #9
commit-bot: I haz the power
10 months ago (2017-04-21 17:31:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a4dae0937f0db75532f6bad4438...

Powered by Google App Engine
This is Rietveld 408576698