Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: components/display_compositor/host_shared_bitmap_manager.cc

Issue 2828353004: Remove HostSharedBitmapManager::AllocateSharedBitmapForChild (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/display_compositor/host_shared_bitmap_manager.cc
diff --git a/components/display_compositor/host_shared_bitmap_manager.cc b/components/display_compositor/host_shared_bitmap_manager.cc
index cd914f54084b43833d13b9cb5d42ecaff12b0a0c..a72ab9498184c164608904efbd0a05729a2d1fa9 100644
--- a/components/display_compositor/host_shared_bitmap_manager.cc
+++ b/components/display_compositor/host_shared_bitmap_manager.cc
@@ -86,19 +86,6 @@ void HostSharedBitmapManagerClient::DidAllocateSharedBitmap(
this->ChildAllocatedSharedBitmap(size, memory_handle, id);
}
-void HostSharedBitmapManagerClient::AllocateSharedBitmapForChild(
- base::ProcessHandle process_handle,
- size_t buffer_size,
- const cc::SharedBitmapId& id,
- base::SharedMemoryHandle* shared_memory_handle) {
- manager_->AllocateSharedBitmapForChild(process_handle, buffer_size, id,
- shared_memory_handle);
- if (*shared_memory_handle != base::SharedMemory::NULLHandle()) {
- base::AutoLock lock(lock_);
- owned_bitmaps_.insert(id);
- }
-}
-
void HostSharedBitmapManagerClient::ChildAllocatedSharedBitmap(
size_t buffer_size,
const base::SharedMemoryHandle& handle,
@@ -215,35 +202,6 @@ bool HostSharedBitmapManager::ChildAllocatedSharedBitmap(
return true;
}
-void HostSharedBitmapManager::AllocateSharedBitmapForChild(
- base::ProcessHandle process_handle,
- size_t buffer_size,
- const cc::SharedBitmapId& id,
- base::SharedMemoryHandle* shared_memory_handle) {
- base::AutoLock lock(lock_);
- if (handle_map_.find(id) != handle_map_.end()) {
- *shared_memory_handle = base::SharedMemory::NULLHandle();
- return;
- }
- std::unique_ptr<base::SharedMemory> shared_memory(new base::SharedMemory);
- if (!shared_memory->CreateAndMapAnonymous(buffer_size)) {
- LOG(ERROR) << "Cannot create shared memory buffer";
- *shared_memory_handle = base::SharedMemory::NULLHandle();
- return;
- }
-
- scoped_refptr<BitmapData> data(new BitmapData(buffer_size));
- data->memory = std::move(shared_memory);
-
- handle_map_[id] = data;
- if (!data->memory->ShareToProcess(process_handle, shared_memory_handle)) {
- LOG(ERROR) << "Cannot share shared memory buffer";
- *shared_memory_handle = base::SharedMemory::NULLHandle();
- return;
- }
- data->memory->Close();
-}
-
void HostSharedBitmapManager::ChildDeletedSharedBitmap(
const cc::SharedBitmapId& id) {
base::AutoLock lock(lock_);

Powered by Google App Engine
This is Rietveld 408576698