Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2824823003: DOM-based SVG resource tracking (Closed)

Created:
3 years, 8 months ago by fs
Modified:
3 years, 2 months ago
Reviewers:
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, eae+blinkwatch, leviw+renderwatch, fmalita+watch_chromium.org, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM-based SVG resource tracking Add SVGResourcesCache::resourceReferenceChanged BUG=454767, 661598

Patch Set 1 #

Patch Set 2 : Readd StyleDidChange hook #

Patch Set 3 : Undo ResourceReferenceChanged streamlining #

Patch Set 4 : Stricter typing, more lenient GC #

Patch Set 5 : Rebase #

Patch Set 6 : Update baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -346 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-creation-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-mask-and-object-creation-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-mask-creation-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-clipPath-creation-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-gradient-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-pattern-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-clipPath-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-gradient-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-pattern-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-clipPath-creation-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-gradient-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-pattern-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-clipPath-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-gradient-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-pattern-creation-expected.txt View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/duplicate-ids-remove-first.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/duplicate-ids-remove-first-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-marker-creation-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-mask-and-object-creation-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-late-mask-creation-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 4 5 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IdTargetObserver.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h View 1 3 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 1 2 3 4 3 chunks +27 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.cpp View 1 2 3 4 2 chunks +22 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.h View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp View 1 2 3 4 2 chunks +26 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGClipPathElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 2 3 4 5 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGradientElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMarkerElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h View 1 2 3 3 chunks +32 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp View 1 2 3 4 1 chunk +86 lines, -179 lines 0 comments Download

Messages

Total messages: 22 (22 generated)
fs
The CQ bit was checked by fs@opera.com to run a CQ dry run
3 years, 8 months ago (2017-04-18 11:35:42 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824823003/1
3 years, 8 months ago (2017-04-18 11:36:03 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 12:44:43 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/432517)
3 years, 8 months ago (2017-04-18 12:44:44 UTC) #4
fs
The CQ bit was checked by fs@opera.com to run a CQ dry run
3 years, 8 months ago (2017-04-18 13:50:42 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824823003/20001
3 years, 8 months ago (2017-04-18 13:51:03 UTC) #6
fs
The CQ bit was checked by fs@opera.com to run a CQ dry run
3 years, 8 months ago (2017-04-18 15:29:52 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824823003/40001
3 years, 8 months ago (2017-04-18 15:30:03 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 17:27:49 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/433288)
3 years, 8 months ago (2017-04-18 17:27:50 UTC) #10
fs
The CQ bit was checked by fs@opera.com to run a CQ dry run
3 years, 8 months ago (2017-04-19 14:09:34 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824823003/60001
3 years, 8 months ago (2017-04-19 14:10:10 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 15:22:02 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/433861)
3 years, 8 months ago (2017-04-19 15:22:03 UTC) #14
fs
The CQ bit was checked by fs@opera.com to run a CQ dry run
3 years, 7 months ago (2017-05-17 16:07:37 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824823003/80001
3 years, 7 months ago (2017-05-17 16:08:32 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 18:16:02 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457604)
3 years, 7 months ago (2017-05-17 18:16:03 UTC) #18
fs
The CQ bit was checked by fs@opera.com to run a CQ dry run
3 years, 7 months ago (2017-05-18 15:36:48 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824823003/100001
3 years, 7 months ago (2017-05-18 15:37:37 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-18 18:19:27 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 18:19:28 UTC) #22 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698