Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2824823003: DOM-based SVG resource tracking (Closed)
Patch Set: Update baselines Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index af710a5670f2b3475c8303f1f71f48bc76d84b35..b330a9a3a02ad00e454a483317696e791c5de2e3 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -117,6 +117,7 @@
#include "core/layout/LayoutTextFragment.h"
#include "core/layout/api/LayoutBoxItem.h"
#include "core/layout/api/LayoutViewItem.h"
+#include "core/layout/svg/SVGResources.h"
#include "core/loader/DocumentLoader.h"
#include "core/page/ChromeClient.h"
#include "core/page/FocusController.h"
@@ -132,7 +133,6 @@
#include "core/probe/CoreProbes.h"
#include "core/svg/SVGAElement.h"
#include "core/svg/SVGElement.h"
-#include "core/svg/SVGTreeScopeResources.h"
#include "platform/EventDispatchForbiddenScope.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/bindings/DOMDataStore.h"
@@ -1705,11 +1705,8 @@ void Element::RemovedFrom(ContainerNode* insertion_point) {
if (this == GetDocument().CssTarget())
GetDocument().SetCSSTarget(nullptr);
- if (HasPendingResources()) {
- GetTreeScope()
- .EnsureSVGTreeScopedResources()
- .RemoveElementFromPendingResources(*this);
- }
+ if (HasPendingResources())
+ SVGResources::RemoveWatchesForElement(*this);
if (GetCustomElementState() == CustomElementState::kCustom)
CustomElement::EnqueueDisconnectedCallback(this);

Powered by Google App Engine
This is Rietveld 408576698