Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2824823003: DOM-based SVG resource tracking (Closed)
Patch Set: Update baselines Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp
index 7b4e56a8a23972bcac4f9cb85c3c094d1bd6504e..eefbe64c738cf36b0b220cfb899ca45afb3aaf5a 100644
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -50,7 +50,6 @@
#include "core/svg/SVGGraphicsElement.h"
#include "core/svg/SVGSVGElement.h"
#include "core/svg/SVGTitleElement.h"
-#include "core/svg/SVGTreeScopeResources.h"
#include "core/svg/SVGUseElement.h"
#include "core/svg/properties/SVGProperty.h"
#include "platform/wtf/AutoReset.h"
@@ -110,13 +109,6 @@ void SVGElement::WillRecalcStyle(StyleRecalcChange change) {
SvgRareData()->SetNeedsOverrideComputedStyleUpdate();
}
-void SVGElement::BuildPendingResourcesIfNeeded() {
- if (!NeedsPendingResourceHandling() || !isConnected() || InUseShadowTree())
- return;
- GetTreeScope().EnsureSVGTreeScopedResources().NotifyResourceAvailable(
- GetIdAttribute());
-}
-
SVGElementRareData* SVGElement::EnsureSVGRareData() {
if (HasSVGRareData())
return SvgRareData();
@@ -407,7 +399,6 @@ Node::InsertionNotificationRequest SVGElement::InsertedInto(
ContainerNode* root_parent) {
Element::InsertedInto(root_parent);
UpdateRelativeLengthsInformation();
- BuildPendingResourcesIfNeeded();
if (hasAttribute(nonceAttr) && getAttribute(nonceAttr) != g_empty_atom) {
setNonce(getAttribute(nonceAttr));
@@ -417,7 +408,6 @@ Node::InsertionNotificationRequest SVGElement::InsertedInto(
setAttribute(nonceAttr, g_empty_atom);
}
}
-
return kInsertionDone;
}
@@ -971,16 +961,6 @@ void SVGElement::AttributeChanged(const AttributeModificationParams& params) {
if (params.name == HTMLNames::idAttr) {
RebuildAllIncomingReferences();
-
- LayoutObject* object = GetLayoutObject();
- // Notify resources about id changes, this is important as we cache
- // resources by id in SVGDocumentExtensions
- if (object && object->IsSVGResourceContainer()) {
- ToLayoutSVGResourceContainer(object)->IdChanged(params.old_value,
- params.new_value);
- }
- if (isConnected())
- BuildPendingResourcesIfNeeded();
InvalidateInstances();
return;
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.h ('k') | third_party/WebKit/Source/core/svg/SVGFilterElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698