Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2779723003:
Add DCHECKs to WebFrameTestClient to assert WebFrameClient params. (Closed)
DescriptionAdd DCHECKs to WebFrameTestClient to assert WebFrameClient params.
Since the WebLocalFrame* parameter being passed is already available
from WebFrameTestClient, these should always match. This is pre-work to
remove the (now redundant) parameter since it's already available from
inside the method.
BUG=361765
Review-Url: https://codereview.chromium.org/2779723003
Cr-Commit-Position: refs/heads/master@{#460266}
Committed: https://chromium.googlesource.com/chromium/src/+/efc29a479db297f2b0077cb15996f461d04cb66b
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sashab@chromium.org changed reviewers: + slangley@chromium.org
Description was changed from ========== Add DCHECKs to WebFrameTestClient to assert WebFrameClient params. BUG=361765 ========== to ========== Add DCHECKs to WebFrameTestClient to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebFrameTestClient, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 ==========
lgtm
sashab@chromium.org changed reviewers: + dcheng@chromium.org
LGTM
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sashab@chromium.org changed reviewers: + avi@chromium.org
avi ptal :)
lgtm
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490757404018690, "parent_rev":
"b30c149bc6b38870ca74cb8dcd5fb34e90e75480", "commit_rev":
"efc29a479db297f2b0077cb15996f461d04cb66b"}
Message was sent while issue was closed.
Description was changed from ========== Add DCHECKs to WebFrameTestClient to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebFrameTestClient, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 ========== to ========== Add DCHECKs to WebFrameTestClient to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebFrameTestClient, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 Review-Url: https://codereview.chromium.org/2779723003 Cr-Commit-Position: refs/heads/master@{#460266} Committed: https://chromium.googlesource.com/chromium/src/+/efc29a479db297f2b0077cb15996... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/efc29a479db297f2b0077cb15996... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
