Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: content/shell/test_runner/web_frame_test_client.cc

Issue 2779723003: Add DCHECKs to WebFrameTestClient to assert WebFrameClient params. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/test_runner/web_frame_test_client.cc
diff --git a/content/shell/test_runner/web_frame_test_client.cc b/content/shell/test_runner/web_frame_test_client.cc
index f8fd9e9e4ad7fef3c6ee8e63816cf47e2dfab003..35f8fdb650e61373cf270745b195f64ef4f91278 100644
--- a/content/shell/test_runner/web_frame_test_client.cc
+++ b/content/shell/test_runner/web_frame_test_client.cc
@@ -438,6 +438,7 @@ void WebFrameTestClient::didStartProvisionalLoad(
void WebFrameTestClient::didReceiveServerRedirectForProvisionalLoad(
blink::WebLocalFrame* frame) {
+ DCHECK_EQ(frame, web_frame_test_proxy_base_->web_frame());
if (test_runner()->shouldDumpFrameLoadCallbacks()) {
PrintFrameDescription(delegate_, frame);
delegate_->PrintMessage(
@@ -488,6 +489,7 @@ void WebFrameTestClient::didChangeIcon(blink::WebLocalFrame* frame,
}
void WebFrameTestClient::didFinishDocumentLoad(blink::WebLocalFrame* frame) {
+ DCHECK_EQ(frame, web_frame_test_proxy_base_->web_frame());
if (test_runner()->shouldDumpFrameLoadCallbacks()) {
PrintFrameDescription(delegate_, frame);
delegate_->PrintMessage(" - didFinishDocumentLoadForFrame\n");
@@ -495,6 +497,7 @@ void WebFrameTestClient::didFinishDocumentLoad(blink::WebLocalFrame* frame) {
}
void WebFrameTestClient::didHandleOnloadEvents(blink::WebLocalFrame* frame) {
+ DCHECK_EQ(frame, web_frame_test_proxy_base_->web_frame());
if (test_runner()->shouldDumpFrameLoadCallbacks()) {
PrintFrameDescription(delegate_, frame);
delegate_->PrintMessage(" - didHandleOnloadEventsForFrame\n");
@@ -511,6 +514,7 @@ void WebFrameTestClient::didFailLoad(blink::WebLocalFrame* frame,
}
void WebFrameTestClient::didFinishLoad(blink::WebLocalFrame* frame) {
+ DCHECK_EQ(frame, web_frame_test_proxy_base_->web_frame());
if (test_runner()->shouldDumpFrameLoadCallbacks()) {
PrintFrameDescription(delegate_, frame);
delegate_->PrintMessage(" - didFinishLoadForFrame\n");
@@ -728,6 +732,7 @@ void WebFrameTestClient::checkIfAudioSinkExistsAndIsAuthorized(
}
void WebFrameTestClient::didClearWindowObject(blink::WebLocalFrame* frame) {
+ DCHECK_EQ(frame, web_frame_test_proxy_base_->web_frame());
web_view_test_proxy_base_->test_interfaces()->BindTo(frame);
web_view_test_proxy_base_->BindTo(frame);
delegate_->GetWebWidgetTestProxyBase(frame)->BindTo(frame);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698