Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2760103002: Merge WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME and ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by pkotwicz
Modified:
3 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME and ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME BUG=702027 Review-Url: https://codereview.chromium.org/2760103002 Cr-Commit-Position: refs/heads/master@{#458423} Committed: https://chromium.googlesource.com/chromium/src/+/763a6232141799360238b6f53b728525c171d7bf

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into package_name #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java View 1 2 chunks +2 lines, -1 line 1 comment Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 8 (4 generated)
pkotwicz
Dominick, can you please take a look?
3 months ago (2017-03-20 21:17:44 UTC) #2
dominickn
lgtm https://codereview.chromium.org/2760103002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java (right): https://codereview.chromium.org/2760103002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java#newcode18 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java:18: import org.chromium.webapk.lib.common.WebApkConstants; I think you can revert the ...
3 months ago (2017-03-20 23:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760103002/20001
3 months ago (2017-03-21 14:59:36 UTC) #5
commit-bot: I haz the power
3 months ago (2017-03-21 15:39:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/763a6232141799360238b6f53b72...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318