chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java - Issue 2760103002: Merge WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME and ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java

Issue 2760103002: Merge WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME and ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME (Closed)

Patch Set: Merge branch 'master' into package_name Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java

index 9b95ea93e5db259d8c021c9ecbd57b6cbbeb0312..27893265b23d0f08c6023e93ea3af21442ace207 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java

@@ -48,7 +48,7 @@ public class WebApkInfo extends WebappInfo {

public static WebApkInfo create(Intent intent) {

String webApkPackageName =

- IntentUtils.safeGetStringExtra(intent, ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME);

+ IntentUtils.safeGetStringExtra(intent, WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME);

if (TextUtils.isEmpty(webApkPackageName)) {

return null;

}

@@ -193,7 +193,7 @@ public class WebApkInfo extends WebappInfo {

// For launching a {@link WebApkActivity}.

intent.putExtra(ShortcutHelper.EXTRA_URL, uri().toString());

intent.putExtra(ShortcutHelper.EXTRA_SOURCE, source());

- intent.putExtra(ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME, webApkPackageName());

+ intent.putExtra(WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME, webApkPackageName());

}

/**